Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow to create release from tags #33

Merged
merged 5 commits into from
Aug 31, 2023

Conversation

EduardoJM
Copy link
Contributor

@EduardoJM EduardoJM commented Aug 26, 2023

Propose to closes #29


This workflow proposes an workflow to run:

  1. a Windows job to build the Windows version of the electron app.
  2. a MacOS job to build the MacOS version of the elctron app.
  3. a Ubuntu job that get the artifacts builded in the above jobs and create the GitHub release.

I decided to use this way to get more control for releasing than using electron-builder --publish(like changing release body text, adding other files as the APK's or add automatic release to an web store if needed).


Another important thing is: is needed to create an new access token with permission to create release and add as GITHUB_TOKEN secret.

Update:

  1. I added an new job to release the Linux AppImage version of the application.

  2. I removed the original workflows publish.yml and test.yml, because the actions are disabled for this repository, then i supposed that are not working.

@EduardoJM
Copy link
Contributor Author

Hi @willianrod i update this today, and added the Linux AppImage release support and, really removed the old workflows (because the actions are disabled on this repository).

Copy link
Owner

@willianrod willianrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for your contribution ;)

@willianrod willianrod merged commit 13ea29a into willianrod:main Aug 31, 2023
@EduardoJM
Copy link
Contributor Author

I have got this same error on Windows with old setup node action version, but in a private test repository, only update to more recent setup-node fixed 😢

image

@willianrod
Copy link
Owner

@EduardoJM which version have you used?

@EduardoJM
Copy link
Contributor Author

@EduardoJM which version have you used?

The version actions/setup-node@v3 (in the workflow). I have update from v2 to v3 to solve the problem.

But, now, the action was successful runned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GitHub Actions to deploy the app automatically on every new tag
2 participants