Bump @vx/text version #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vx/text creates an invisible svg to measure text width, but in previous versions doesn't make the svg `absolute` positioned. https://github.com/hshoff/vx/blame/013f2abd5fee794ea0c246e9d1de08559817af68/packages/vx-text/src/util/getStringWidth.js
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
=======================================
Coverage 80.54% 80.54%
=======================================
Files 109 109
Lines 2426 2426
Branches 568 568
=======================================
Hits 1954 1954
Misses 291 291
Partials 181 181Continue to review full report at Codecov.
|
|
👌 thanks for fixing this. noting original |
|
@schillerk should be fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vx/text creates an invisible svg to measure text width, but in previous versions doesn't make the svg
absolutepositioned.https://github.com/hshoff/vx/blame/013f2abd5fee794ea0c246e9d1de08559817af68/packages/vx-text/src/util/getStringWidth.js
💔 Breaking Changes
🏆 Enhancements
📜 Documentation
🐛 Bug Fix
🏠 Internal