adding option to fill scrollbar gap #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmcpo
reviewed
May 3, 2018
| @@ -62,7 +77,7 @@ const handleScroll = (event: HandleScrollEvent, targetElement: any): boolean => | |||
| return true; | |||
| }; | |||
|
|
|||
| export const disableBodyScroll = (targetElement: any): void => { | |||
| export const disableBodyScroll = (targetElement: any, options?: BodyScrollOptions): void => { | |||
There was a problem hiding this comment.
would you need to apply the same options to enableBodyScroll on line 124?
There was a problem hiding this comment.
No, that's not really necessary. Padding is automatically reset when setOverflowAuto() is called. I can't imagine a use case where you want to fill the gap but don't want to reset it.
willmcpo
reviewed
May 3, 2018
src/bodyScrollLock.js
Outdated
| @@ -22,10 +27,16 @@ const preventDefault = (rawEvent: HandleScrollEvent): boolean => { | |||
| return false; | |||
| }; | |||
|
|
|||
| const setOverflowHidden = () => { | |||
| const setOverflowHidden = (options?: BodyScrollOptions) => { | |||
| const reserveScrollBarGab = !!options && options.reserveScrollBarGap === true; | |||
There was a problem hiding this comment.
just a typo here reserveScrollBarGap instead of reserveScrollBarGab
|
Could you also update the README @martinkutter re the options parameter? then we're good to go, thanks for the PR |
|
@willmcpo I fixed the typo and added a suggestion for the documentation. |
willmcpo
approved these changes
May 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.