Enchance property wrapper resolution #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafcabezas
force-pushed
the
feature/enhance-property-wrapper-resolution
branch
from
22fda5d
to
dea0d2c
Compare
|
LGTM |
vcsoares
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves property-wrapper resolution by making sure it always happens at the point of use of the dependency. This solves bugs where, if the a new dependency is registered, the old one would potentially still be referenced by the code.
Also, since resolution won't happen on property wrapper instantiation, then the dependency type will need to be specified at this time, changing the syntax from:
to