Skip to content
This repository has been archived by the owner on Jul 1, 2023. It is now read-only.

0.8.0 #89

Merged
merged 27 commits into from
May 16, 2020
Merged

0.8.0 #89

merged 27 commits into from
May 16, 2020

Conversation

willwull
Copy link
Owner

@willwull willwull commented May 12, 2020

New:

  • Added posts and comments to user pages, fixes Implement user pages #85
  • Upgraded react-scripts, typescript, prettier, react-redux, react-router-dom for optional chaining and other type improvements
  • Only show "Read full description" on subreddits if the full description exists and is different from the short description.
  • Misc performance improvements.
    • Removed some unnecessary renders when toggling sidebar
    • Refactored search bar -- each change no longer triggers a redux action
  • Subreddit data is cached, so the subsequent visits will show the banner, icon, etc immediately for a smoother experience.
    • Fresh data is still being fetched and will replace the cached data on the first visit per session.
  • Uninstall intersection-observer. The feature is supported across all major browsers, so the polyfill isn't needed anymore.
  • Uninstall prop-types. I should have removed this long ago since I'm using TS for types.
  • Lower line-height of CommentContext from 1.75 to 1.5. Not sure why it was ever so high?
  • Set up ESLint to lint TypeScript code. TSLint was somewhat unreliable I found, and didn't show anything in the editor? Maybe I configured it incorrectly, but it's apparently deprecated now anyway.

Bug fixes:

  • Fix subscription caching issue, fixes User's subscriptions aren't cached properly #67
    • Fixed by making the "init snoowrap" action also handle fetching the subscriptions. Otherwise, there would be a data race between getting the username and getting the subscriptions.
  • The user menu now displays the guest menu if the user data is for some reason null, even if the user is logged in.
  • Added an error boundary around the post content, which should hopefully prevent the entire app from crashing if something goes wrong, fixes Page crashes due to post content #88
    • Fixed an error where trying to read the width and height of a imgur gifv crashed the app.
  • Fix the popovers class so the body can be scrolled again when the popovers unmount, fixes Can't scroll after logging out #87

@willwull willwull added the WIP Work in progress, don't merge label May 12, 2020
@willwull willwull changed the title 0.7.8 0.8.0 May 16, 2020
@willwull willwull removed the WIP Work in progress, don't merge label May 16, 2020
@willwull willwull merged commit 9038059 into master May 16, 2020
@willwull willwull deleted the dev branch May 16, 2020 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant