Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The adjust made on dates (from and to) in bizdays should be moved to generics and treated as options and parameters #9

Closed
wilsonfreitas opened this issue Nov 22, 2013 · 2 comments
Closed

The adjust made on dates (from and to) in bizdays should be moved to generics and treated as options and parameters #9

wilsonfreitas opened this issue Nov 22, 2013 · 2 comments
Assignees
@wilsonfreitas
Labels
enhancement

Comments

@wilsonfreitas
Copy link
Owner

No description provided.

@wilsonfreitas wilsonfreitas mentioned this issue Nov 22, 2013
Closed
@wilsonfreitas
Copy link
Owner Author

bizdays call should look like:

bizdays(from, to, cal, adjust.from=adjust.next, adjust.to=adjust.previous)

This setup represents the Excel behavior, but once these arguments are provided any user will be able to set them accordingly their own needs.

wilsonfreitas added a commit that referenced this issue May 26, 2014
@wilsonfreitas
Calendar's adjustments arguments
c329ed3 
Two new arguments have been added to `Calendar` function: `adjust.from` and `adjust.to`.
These arguments are used as filters for `bizdays` arguments `from` and `to`.
The default setting is `adjust.from=adjust.next` and `adjust.to=adjust.previous` and that reproduces the Excel's behavior.

The original issue was to implement these arguments directly in `bizdays` function, but implementing it in `Calendar` reinforces its portability.

#9
@wilsonfreitas wilsonfreitas self-assigned this May 26, 2014
@wilsonfreitas
Copy link
Owner Author

Done in Calendar, not in bizdays, but I think this is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilsonfreitas wilsonfreitas

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wilsonfreitas