Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Driver selector to Connection setup wizard #2436

Merged

Conversation

shampeon
Copy link
Contributor

@shampeon shampeon commented Jan 23, 2024

This PR adds a combo box for selecting the Driver in the Connection setup wizard.

Fixes #2425.

To do:

  • Fix layout issue with Connect button being hidden.
  • Move labels/descriptions to localization bundle.

@shampeon
Copy link
Contributor Author

I'm seeing a layout problem where the Connect button is pushed to be barely visible, but no scroll bars appear.
Screen Shot 2024-01-22 at 5 52 38 PM

Ideally, the Setup Wizard panel would expand on the y axis to fit the full ConnectionPanel elements.

@shampeon shampeon marked this pull request as ready for review January 23, 2024 03:53
@breiler breiler merged commit 494e985 into winder:master Jan 23, 2024
1 of 2 checks passed
@breiler
Copy link
Collaborator

breiler commented Jan 23, 2024

Thanks

@shampeon shampeon deleted the add-driver-selector-to-connection-wizard branch January 23, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal to enhance Setup wizard for FluidNC
2 participants