fix(frontend): Fix path overflow on the Runs page #3781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 45f323f in 1 minute and 8 seconds
More details
- Looked at
43lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/lib/components/runs/RunRow.svelte:227
- Draft comment:
The hardcoded pixel value48used in the style calculation formax-widthmight not be flexible or accurate for different layouts or future design changes. Consider calculating this value dynamically based on the actual widths of sibling elements or use a more responsive design approach. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_SgOGYfE0tPexbv8O
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Deploying windmill with
|
| Latest commit: |
45f323f
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4d6acaa8.windmill.pages.dev |
| Branch Preview URL: | https://triggerd-by-max-width.windmill.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR fixes text overflow issues on the 'Runs' page by dynamically adjusting the maximum width of the schedule path display based on the container's client width.
Key points:
RunRow.svelteto handle dynamic text overflow for schedule paths.triggeredByWidthto capture the client width of the container.max-widthto the schedule path text based on thetriggeredByWidth.Generated with ❤️ by ellipsis.dev