Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUPRULE-401: eap 7.3 maven-jboss-rmi-api_1.0_spec rule #391

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

emmartins
Copy link
Contributor

Issue: https://issues.jboss.org/browse/WINDUPRULE-401
Please do not merge, link tag to be fixed once EAP 7.3 is released

@mrizzi mrizzi requested a review from m-brophy January 13, 2020 14:04
Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment to remove the link according to what @emmartins proposed.

Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor change to improve consistency in rules' messages.

Copy link
Member

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rule looks good to me, thanks @emmartins 👍

@mrizzi mrizzi merged commit 37f0533 into windup:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants