Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WINDUPRULE-722: quarkus1-12 distroless image rule #537

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

m-brophy
Copy link
Contributor

@m-brophy m-brophy commented Mar 1, 2021

@PhilipCattanach
Copy link
Contributor

PhilipCattanach commented Mar 1, 2021

Hi @m-brophy just a couple of minor things
1). The description tag is still referring to Fast-jar as default rather than distroless image
2). The message needs to change the background color of the image names.

@PhilipCattanach
Copy link
Contributor

All good - thanks @m-brophy

@PhilipCattanach PhilipCattanach merged commit b290ae6 into windup:master Mar 2, 2021
PhilipCattanach pushed a commit to PhilipCattanach/windup-rulesets that referenced this pull request Mar 3, 2021
* WINDUPRULE-722: quarkus1-12 distroless image rule (windup#537)

* WINDUPRULE-722: quarkus1-12 distroless image rule

* WINDUPRULE-722: add meaningful rule description and fix message background

* WINDUPRULE-722: different background in message for artifacts

* WINDUPRULE-718 Quarkus 1.12 Vert.x (windup#539)

* Moved to XML rule and improved formatting

Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com>
mrizzi added a commit that referenced this pull request Mar 5, 2021
* WINDUPRULE-721 Quarkus Release 1.12 - Quarkus Maven Plugin

* Moved to XML rule and improved formatting (#2)

* WINDUPRULE-722: quarkus1-12 distroless image rule (#537)

* WINDUPRULE-722: quarkus1-12 distroless image rule

* WINDUPRULE-722: add meaningful rule description and fix message background

* WINDUPRULE-722: different background in message for artifacts

* WINDUPRULE-718 Quarkus 1.12 Vert.x (#539)

* Moved to XML rule and improved formatting

Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com>

Co-authored-by: Marco Rizzi <mrizzi@users.noreply.github.com>
Co-authored-by: Mark Brophy <36955467+m-brophy@users.noreply.github.com>
@m-brophy m-brophy deleted the WINDUPRULE-722 branch March 28, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants