Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AWS target for redis winglib #2171

Open
ekeren opened this issue Apr 20, 2023 · 10 comments
Open

Support AWS target for redis winglib #2171

ekeren opened this issue Apr 20, 2023 · 10 comments
Labels
☁️ aws Related to Amazon Web Services support 📚 libraries Wing Libraries 🎨 sdk SDK

Comments

@ekeren
Copy link

ekeren commented Apr 20, 2023

I keep trying to write the following code:

bring redis;

let redis = new redis.Redis(); // PROBLEM

But the above code doesn't compile because the redis keyword is already taken

One option was to replace it with experimental, but this word feels too long.

@staycoolcall911 staycoolcall911 added 🎨 sdk SDK good first issue Good for newcomers labels Apr 20, 2023
@Chriscbr
Copy link
Contributor

Chriscbr commented Apr 20, 2023

As an experiment I tried writing

bring redis as experimental;

But when I do this today, I get a bug:

error: Unknown symbol "Redis" in namespace "redis"
  --> hello.w:4:26
  |
4 | let r = new experimental.Redis();
  |                          ^^^^^ Unknown symbol "Redis" in namespace "redis"

@ekeren ekeren changed the title replace bring redis with bring misc public redis as a third party library Jun 12, 2023
@ekeren ekeren changed the title public redis as a third party library publish redis as a third party library Jun 12, 2023
@staycoolcall911 staycoolcall911 removed the good first issue Good for newcomers label Jul 20, 2023
@staycoolcall911 staycoolcall911 added this to the Containers milestone Sep 12, 2023
@itssubhodiproy
Copy link
Contributor

Hi @Chriscbr @staycoolcall911, I would like to work on this. Can you assign this to me?

@staycoolcall911
Copy link
Contributor

Hey @subh-cs thank you! However this task is dependent on Chris's current task #130, so let's wait for after it is done.

@Chriscbr Chriscbr mentioned this issue Oct 4, 2023
5 tasks
mergify bot pushed a commit that referenced this issue Oct 5, 2023
Introduces the `wing pack` command - a standard way to package libraries in Wing.

`wing pack` can be run in any Wing project directory that has a `package.json` in it. `wing pack` will validate your `package.json` produce a tarball that contains the libraries source files. For more documentation, see https://winglang.io/docs/libraries.

## Implementation

When you `bring "foo"`, the parser now performs some Node module resolution to look up the `foo` package and see if it's a JSII library or a Wing library based on its `package.json`. If `bring "foo"` refers to a Wing library, then it's equivalent to bringing that library's root directory, per #4210.

## Future related work
- #4415
- #4294
- #2171

## Checklist

- [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [x] Tests added (always)
- [x] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@itssubhodiproy
Copy link
Contributor

Hi @staycoolcall911, Can I start working on this? as it seems that #130 has been completed successfully.

@staycoolcall911
Copy link
Contributor

Yes, I think you can start. Assigned to you.
Note that @eladb is working on publishing a library for #4350 (Wing Containers Library) - you can see his work on this repo and also a captain's log on Slack.

@itssubhodiproy
Copy link
Contributor

Thanks for the reference.

@Chriscbr
Copy link
Contributor

@winglibs/redis is now published on npm - great job @subh-cs! 🎉

@itssubhodiproy
Copy link
Contributor

itssubhodiproy commented Dec 20, 2023

Hi @Chriscbr , please don't close this issue because @winglibs/redis doesn't have tf-aws support but ex.Redis() has.
See this

@staycoolcall911
Copy link
Contributor

Thanks for keeping it organized @subh-cs and @Chriscbr 🙏

@Chriscbr Chriscbr changed the title publish redis as a third party library Support AWS target for redis winglib Apr 4, 2024
@Chriscbr Chriscbr added the ☁️ aws Related to Amazon Web Services support label Apr 4, 2024
@Chriscbr Chriscbr mentioned this issue Apr 4, 2024
3 tasks
Copy link

github-actions bot commented Jul 7, 2024

Hi,

This issue hasn't seen activity in 90 days. Therefore, we are marking this issue as stale for now. It will be closed after 7 days.
Feel free to re-open this issue when there's an update or relevant information to be added.
Thanks!

@github-actions github-actions bot added the Stale label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☁️ aws Related to Amazon Web Services support 📚 libraries Wing Libraries 🎨 sdk SDK
Projects
Status: 🤝 Backlog - handoff to owners
Development

No branches or pull requests

4 participants