Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wing sdk tests #2 - allow more targets #3914

Closed
tsuf239 opened this issue Aug 21, 2023 · 3 comments · Fixed by #4500
Closed

Wing sdk tests #2 - allow more targets #3914

tsuf239 opened this issue Aug 21, 2023 · 3 comments · Fixed by #4500
Assignees
@tsuf239
Labels
✨ enhancement New feature or request 🎨 sdk SDK 🧪 testing
Milestone
KubeCon23

Comments

@tsuf239
Copy link
Contributor

tsuf239 commented Aug 21, 2023 •
edited
Loading

Feature Spec

  • Adding tf-azure target to the test command,
  • Finding a systematic way to skip tests for resources that are not yet implemented

Use Cases

testing

Implementation Notes

No response

Component

SDK

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
@tsuf239 tsuf239 added the ✨ enhancement New feature or request label Aug 21, 2023
@tsuf239 tsuf239 self-assigned this Aug 21, 2023
@garysassano
Copy link
Collaborator

Is there an azure target now, different from tf-azure?

@tsuf239
Copy link
Contributor Author

tsuf239 commented Sep 5, 2023

Is there an azure target now, different from tf-azure?

they are the same, fixed the description

@staycoolcall911 staycoolcall911 added this to the KubeCon23 milestone Sep 13, 2023
@tsuf239 tsuf239 mentioned this issue Sep 14, 2023
Closed
@tsuf239 tsuf239 mentioned this issue Sep 27, 2023
Merged
5 tasks
mergify bot pushed a commit that referenced this issue Oct 1, 2023
@tsuf239
fix(sdk): fix cloud.function timeout to match 1m default (#4304)
b684cfd 
Noticed that today (took less time to fix than to open an issue)
Tested on awscdk:
<img width="763" alt="image" src="https://github.com/winglang/wing/assets/39455181/75389558-2860-4e39-8f99-d436b7fe47c0">
and tf-aws:
<img width="709" alt="image" src="https://github.com/winglang/wing/assets/39455181/0c301b4c-0232-499c-896f-b36ebadab496">

Haven't tested on azure (will be done after that task: #3914 )

Please allow merge only after #4245 

## Checklist

- [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [x] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@tsuf239 tsuf239 mentioned this issue Oct 10, 2023
Merged
5 tasks
@mergify mergify bot closed this as completed in #4500 Oct 17, 2023
mergify bot pushed a commit that referenced this issue Oct 17, 2023
@tsuf239
feat(sdk): adding inflight function, application insights and test to…
9b36f88 
… tfazure (#4500)

## Checklist
fixes:  #1371
fixes: #3914 
<img width="566" alt="image" src="https://github.com/winglang/wing/assets/39455181/989e7f48-d76d-403c-9119-d6b511d8a9c9">

Added (to tf-azure):
- inflight function client
 - application insights (a resource to collect logs, otherwise debugging is very inconvenient), 
 - test runner 

Also:
 - adjusted the test tf aws function to support any tf target
 - renamed the `WING_TEST_RUNNER_FUNCTION_ARNS` constant to `WING_TEST_RUNNER_FUNCTION_ARNS` to fit the adjustment (that changed around 20 snapshot files) 

All the code containing and tests containing files are on the first commit, the second commit is only snap changes.

Opened the following follow-up issues: 
#4494 
#4497

- [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [x] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.39.14.

ainvoner pushed a commit that referenced this issue Oct 17, 2023
@tsuf239 @ainvoner
feat(sdk): adding inflight function, application insights and test to…
b6ced8f 
… tfazure (#4500)

## Checklist
fixes:  #1371
fixes: #3914 
<img width="566" alt="image" src="https://github.com/winglang/wing/assets/39455181/989e7f48-d76d-403c-9119-d6b511d8a9c9">

Added (to tf-azure):
- inflight function client
 - application insights (a resource to collect logs, otherwise debugging is very inconvenient), 
 - test runner 

Also:
 - adjusted the test tf aws function to support any tf target
 - renamed the `WING_TEST_RUNNER_FUNCTION_ARNS` constant to `WING_TEST_RUNNER_FUNCTION_ARNS` to fit the adjustment (that changed around 20 snapshot files) 

All the code containing and tests containing files are on the first commit, the second commit is only snap changes.

Opened the following follow-up issues: 
#4494 
#4497

- [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [x] Description explains motivation and solution
- [x] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsuf239 tsuf239

Labels
✨ enhancement New feature or request 🎨 sdk SDK 🧪 testing
Projects
Wing
Archived in project
Milestone
KubeCon23
Development

Successfully merging a pull request may close this issue.

feat(sdk): adding inflight function, application insights and test to tfazure winglang/wing
4 participants
@garysassano @tsuf239 @staycoolcall911 @monadabot