-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unable to bring directories with -
, .
and other non symbolic names
#5008
Comments
additional research shows that the culprit the names of the docker image directories in the container test directory: trying to create a minimal reproduction. |
nothing
bring "./test" as t; |
This also happens if there's a directory the starts with |
eladb
added a commit
to winglang/winglibs
that referenced
this issue
Nov 20, 2023
this was caused by winglang/wing#5008 as a workaround, rename the directory names to "_"
eladb
changed the title
unable to bring directories with Nov 20, 2023
unexpected token '-'
when bringing containers
-
, .
and other non symbolic names
eladb
added a commit
to winglang/winglibs
that referenced
this issue
Nov 20, 2023
this was caused by winglang/wing#5008 as a workaround, rename the directory names to "_"
5 tasks
mergify bot
pushed a commit
that referenced
this issue
Nov 23, 2023
…mes (#5017) ## Summary 1. Skip bringing directories where no wing file is found 2. Report a diagnostic error if directory contains non-symbolic character Closes: #5008 Closes: #5009 Closes: #4929 ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [x] Docs updated (only required for features) - [x] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Congrats! 🚀 This was released in Wing 0.49.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I tried this:
main.w
:then:
This happened:
I expected this:
No response
Is there a workaround?
No response
Anything else?
No response
Wing Version
No response
Node.js Version
No response
Platform(s)
No response
Community Notes
The text was updated successfully, but these errors were encountered: