custom platforms can't use this

[skorfmann]

I tried this:

export class Platform implements IPlatform {
  public readonly target = 'tf-aws';
  public readonly foo: string;

  constructor() {
    this.foo = 'bar';
  }

  postSynth(config: any) {
    console.log(this.foo);
    return config
  }
}

This happened:

this is not available

test/platform-production.test.ts > Platform > simple.main.w
Error: Cannot read properties of undefined (reading 'foo')
 ❯ runPreflightCodeInVm ../../../node_modules/.pnpm/@winglang+compiler@0.51.4_constructs@10.3.0/node_modules/@winglang/compiler/dist/index.js:468:11
 ❯ Proxy.compile ../../../node_modules/.pnpm/@winglang+compiler@0.51.4_constructs@10.3.0/node_modules/@winglang/compiler/dist/index.js:401:5
 ❯ test/platform-production.test.ts:31:22

I expected this:

either it should be made clear that the functions are called out of the class context or ideally this should just work as expected.

Is there a workaround?

don't use this

Anything else?

the hooks are collected here

wing/libs/wingsdk/src/platform/platform-manager.ts

Lines 82 to 108 in 0ea8670

	let synthHooks: SynthHooks = {
	preSynthesize: [],
	postSynthesize: [],
	validate: [],
	};
	let newInstanceOverrides: any[] = [];
	this.platformInstances.forEach((instance) => {
	if (instance.preSynth) {
	synthHooks.preSynthesize!.push(instance.preSynth);
	}
	if (instance.postSynth) {
	synthHooks.postSynthesize!.push(instance.postSynth);
	}
	if (instance.validate) {
	synthHooks.validate!.push(instance.validate);
	}
	if (instance.newInstance) {
	newInstanceOverrides.push(instance.newInstance);
	}
	});
	return appCall!({ ...appProps, synthHooks, newInstanceOverrides }) as App;

that's where the hooks are called

wing/libs/wingsdk/src/shared-tf/app.ts

Lines 137 to 144 in 0ea8670

	if (this.synthHooks?.postSynthesize) {
	this.synthHooks.postSynthesize.forEach((hook) => {
	writeFileSync(
	resolve(`${this.outdir}/main.tf.json`),
	JSON.stringify(hook(tfConfig), null, 2)
	);
	});
	}

Wing Version

0.51.7

Node.js Version

18.7

Platform(s)

MacOS

Community Notes

• Please vote by adding a 👍 reaction to the issue to help us prioritize.
• If you are interested to work on this issue, please leave a comment.

[monadabot]

Congrats! 🚀 This was released in Wing 0.54.28.