Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add react-vite template to Wing cli #5928

Closed
ainvoner opened this issue Mar 13, 2024 · 3 comments · Fixed by #5929 or #5969
Closed

Add react-vite template to Wing cli #5928

ainvoner opened this issue Mar 13, 2024 · 3 comments · Fixed by #5929 or #5969
Assignees
@ainvoner
Labels
✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl

Comments

@ainvoner
Copy link
Contributor

Use Case

As part of react-vite use case. Add a new template in Wing: react-vite

Proposed Solution

get the content of react-vite workshop and create a template from that

Implementation Notes

No response

Component

CLI

Community Notes

  • Please vote by adding a 👍 reaction to the issue to help us prioritize.
  • If you are interested to work on this issue, please leave a comment.
  • If this issue is labeled needs-discussion, it means the spec has not been finalized yet. Please reach out on the #dev channel in the Wing Slack.
@ainvoner ainvoner added ✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl labels Mar 13, 2024
@ainvoner ainvoner self-assigned this Mar 13, 2024
@ainvoner ainvoner mentioned this issue Mar 13, 2024
Merged
5 tasks
@mergify mergify bot closed this as completed in #5929 Mar 17, 2024
mergify bot pushed a commit that referenced this issue Mar 17, 2024
@ainvoner
feat(cli): add react-vite template (#5929)
52f0e8f 
As part of react-vite use case.
Based on react-vite-websockets wing workshop.
resolves: #5928

## Checklist

- [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.61.9.

@staycoolcall911
Copy link
Contributor

Reopening since #5929 was reverted

ainvoner added a commit that referenced this issue Mar 18, 2024
@ainvoner
feat(cli): react-vite template
0c0f6b5 
Part of react-vite use case.
Based on react-vite-websockets wing workshop.
resolves: #5928
@ainvoner ainvoner mentioned this issue Mar 18, 2024
Merged
5 tasks
@mergify mergify bot closed this as completed in #5969 Mar 18, 2024
mergify bot pushed a commit that referenced this issue Mar 18, 2024
@ainvoner
feat(cli): react vite template (#5969)
a361e81 
Part of react-vite use case.
Based on react-vite-websockets wing workshop.
resolves: [#5928](#5928)

## Checklist

- [ ] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted)
- [ ] Description explains motivation and solution
- [ ] Tests added (always)
- [ ] Docs updated (only required for features)
- [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing

*By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.61.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainvoner ainvoner

Labels
✨ enhancement New feature or request needs-discussion Further discussion is needed prior to impl
Projects
Wing
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cli): add react-vite template winglang/wing
feat(cli): react vite template winglang/wing
3 participants
@ainvoner @staycoolcall911 @monadabot