fix(cli): breaks without globally installed aws-cdk-lib #3398
Conversation
cdktf is a bundled dependency of @winglang/sdk so it's included in the end package. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Congrats! 🚀 This was released in Wing 0.24.16. |
| @@ -35,10 +34,6 @@ export class Function { | |||
| return host; | |||
| } | |||
|
|
|||
| if (host instanceof AwsCdkFunction) { | |||
There was a problem hiding this comment.
I think duck-typing much be a better approach here.
Basically check that the host implements IAwsFunction's methods.
|
The |
Following @eladb's recommendation in PR #3398, I removed the import of `target-awscdk` and `target-tf-aws`, and checked if the `host` implements the methods of the `IAwsFunction` interface. This way, the error that was occurring due to not having `aws-cdk-lib` globally installed no longer happens. ## Checklist - [x] Title matches [Winglang's style guide](https://www.winglang.io/contributing/start-here/pull_requests#how-are-pull-request-titles-formatted) - [x] Description explains motivation and solution - [x] Tests added (always) - [ ] Docs updated (only required for features) - [ ] Added `pr/e2e-full` label if this feature requires end-to-end testing *By submitting this pull request, I confirm that my contribution is made under the terms of the [Wing Cloud Contribution License](https://github.com/winglang/wing/blob/main/CONTRIBUTION_LICENSE.md)*.
Fixes #3396
This "instanceof" check is causing problems since it results in several other modules to get imported, including those that require
aws-cdk-libto be installed -- even if you're not compiling to theawscdktarget. Removing this code path as a hotfix.Checklist
pr/e2e-fulllabel if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Monada Contribution License.