Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): cloud.OnDeploy #3566

Merged
merged 16 commits into from
Jul 23, 2023
Merged

feat(sdk): cloud.OnDeploy #3566

merged 16 commits into from
Jul 23, 2023

Conversation

Chriscbr
Copy link
Contributor

Closes #1337

See the usage docs in the PR for details.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@Chriscbr Chriscbr requested a review from a team as a code owner July 21, 2023 21:10
Signed-off-by: monada-bot[bot] <monabot@monada.co>
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jul 21, 2023
@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Jul 21, 2023
@Chriscbr
Copy link
Contributor Author

@eladb I remember you mentioned you weren't sure about the name "OnDeploy". I'm happy to switch it to something else (Trigger, Takeoff, LaunchScript, InitHook, etc.) if there's a name that strikes your fancy. Other folks' feedback welcome as well.

@mergify
Copy link
Contributor

mergify bot commented Jul 23, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@Chriscbr
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Jul 23, 2023

refresh

✅ Pull request refreshed

@mergify mergify bot merged commit 96b9e0c into main Jul 23, 2023
11 checks passed
@mergify mergify bot deleted the rybickic/on-deploy branch July 23, 2023 19:21
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.24.43.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cloud.OnDeploy
3 participants