-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk, compiler): displaying logs of tf-aws functions #3622
Conversation
Co-authored-by: Chris Rybicki <chrisr@monada.co>
Signed-off-by: monada-bot[bot] <monabot@monada.co>
I found an interesting way to get the logs in O(1) without any async calls, and without wrapping the string, |
Gave up the logger class idea- chose a much easier approach of changing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - approved conditional on addressing a few small nitpicks. This will be a huge improvement for testing apps on AWS. Once we have more resources on other cloud targets, I imagine we might be able to reuse the approach there as well 🚀
Resolving all comments :) @Chriscbr please let me know if something is missing and I'll push it into a further PR |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Congrats! 🚀 This was released in Wing 0.24.67. |
fixes: #1973
Description
log(...)
outputs when running a test on target tf-awsChecklist
pr/e2e-full
label if this feature requires end-to-end testingBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.