feat(compiler): structural typing for known json objects #3729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-struct-inference
…n-struct-inference
Signed-off-by: monada-bot[bot] <monabot@monada.co>
monadabot
added
the
⚠️ pr/review-mutation
MarkMcCulloh
removed
the
⚠️ pr/review-mutation
…n-struct-inference
…n-struct-inference
…n-struct-inference
Signed-off-by: monada-bot[bot] <monabot@monada.co>
monadabot
added
the
⚠️ pr/review-mutation
MarkMcCulloh
removed
the
⚠️ pr/review-mutation
…n-struct-inference
Signed-off-by: monada-bot[bot] <monabot@monada.co>
monadabot
added
the
⚠️ pr/review-mutation
MarkMcCulloh
removed
the
⚠️ pr/review-mutation
Chriscbr
reviewed
Aug 14, 2023
…n-struct-inference
…n-struct-inference
…n-struct-inference
…n-struct-inference
|
Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/json-struct-inference is up-to-date with main and the queue is empty. |
|
Congrats! 🚀 This was released in Wing 0.25.21. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3697 (it seemed easier to do it this way than to special case adding the struct name)
Fixes #2366
Fixes #2597
Fixes #3848
Mostly putting this up in case anyone wants to see the spec change. The code needs cleanup and a few more test cases need to be added. (it works though!)
The main complications here are due to my recent inference changes, otherwise the implementation is pretty straightforward.
Completions inside Json literals also work like structs if they are being used as a struct.
Misc:
if letif letdid not do inference properlyBy submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.