Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): unable to create array of valid heterogeneous values #3885

Merged
merged 5 commits into from
Aug 18, 2023

Conversation

MarkMcCulloh
Copy link
Contributor

Fixes #3883

Removed a function that didn't really do much, added some comments, and generally tweaked the type-checking for literals

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner August 18, 2023 17:49
tools/hangar/__snapshots__/invalid.ts.snap Show resolved Hide resolved
examples/tests/valid/std_containers.w Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2023

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/hetero-arrays is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 31c52b9 into main Aug 18, 2023
11 checks passed
@mergify mergify bot deleted the mark/hetero-arrays branch August 18, 2023 22:00
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.25.26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot create array of heterogeneous values
3 participants