fix(compiler): missing extended struct fields for some imported JSII interfaces #3982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3716
The core of this change is to make sure that when importing an interface, the type itself is registered before importing the types that it extends. Previously it was the opposite way.
I will say that I'm not sure why this works, the previous implementation makes more sense to me 🤷
No tests were added because I was not able to replicate the issue in other JSII libs other than
cdk8s-plus-27
so I wasn't sure that it's worthwhile to add an additional package just to test this. We also don't have a fixture system for JSII testing.Misc:
By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.