Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): fix typo in compatibility matrix #4093

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix(docs): fix typo in compatibility matrix #4093

merged 1 commit into from
Sep 11, 2023

Conversation

garysassano
Copy link
Collaborator

The target is called awscdk, not aws-cdk.

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@garysassano garysassano requested a review from a team as a code owner September 5, 2023 23:19
@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-4093.fly.dev 🚀

Updated (UTC): 2023-09-05 23:23

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 5, 2023
tsuf239
tsuf239 approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@tsuf239 tsuf239 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please remove those two files from the PR: tools/hangar/__snapshots__/test_corpus/sdk_tests/std/json.w_compile_tf-aws.md
tools/hangar/__snapshots__/test_corpus/sdk_tests/std/json.w_test_sim.md

@tsuf239 tsuf239 removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Sep 11, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023

Thanks for contributing, @garysassano! This PR will now be added to the merge queue, or immediately merged if garysassano/fix-docs-matrix is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 081d133 into main Sep 11, 2023
4 checks passed
@mergify mergify bot deleted the garysassano/fix-docs-matrix branch September 11, 2023 11:55
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.29.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsuf239 tsuf239 tsuf239 approved these changes

Assignees

@tsuf239 tsuf239

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@garysassano @monadabot @tsuf239