Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert(cli): compile directories #4346

Merged
merged 1 commit into from
Sep 29, 2023
Merged

revert(cli): compile directories #4346

merged 1 commit into from
Sep 29, 2023

Conversation

MarkMcCulloh
Copy link
Contributor

@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner September 29, 2023 22:27
@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-4346.fly.dev 🚀

Last Updated (UTC) 2023-09-29 22:31

@MarkMcCulloh MarkMcCulloh changed the title revert: feat(cli): compile directories revert(cli): compile directories Sep 29, 2023
@monadabot
Copy link
Contributor

Benchmarks

Results
name mean min max moe sd
version 88ms 84ms 92ms 3ms 4ms
functions_10.test.w -t sim 761ms 736ms 796ms 10ms 18ms
functions_10.test.w -t tf-aws 4616ms 4531ms 4794ms 37ms 67ms
jsii_big.test.w -t sim 4395ms 4324ms 4495ms 27ms 48ms
jsii_big.test.w -t tf-aws 4558ms 4429ms 4652ms 32ms 58ms
hello_world.test.w -t sim 665ms 646ms 680ms 6ms 11ms
hello_world.test.w -t tf-aws 5497ms 5390ms 5715ms 40ms 73ms
empty.test.w -t sim 619ms 604ms 700ms 13ms 24ms
empty.test.w -t tf-aws 779ms 765ms 799ms 7ms 13ms
jsii_small.test.w -t sim 623ms 602ms 683ms 12ms 21ms
jsii_small.test.w -t tf-aws 785ms 761ms 806ms 7ms 12ms
functions_1.test.w -t sim 700ms 677ms 754ms 12ms 22ms
functions_1.test.w -t tf-aws 2448ms 2166ms 2755ms 62ms 112ms
Comparison to main
Benchmark Before After Change
version 102ms±4.02 88ms±2.58 -14ms (-14.08%)🟩
functions_10.test.w -t sim 894ms±13.74 761ms±9.86 -133ms (-14.87%)🟩
functions_10.test.w -t tf-aws 5388ms±45.1 4616ms±37.13 -772ms (-14.34%)🟩
jsii_big.test.w -t sim 4895ms±59.82 4395ms±26.67 -500ms (-10.21%)🟩
jsii_big.test.w -t tf-aws 5176ms±73.13 4558ms±32.22 -618ms (-11.95%)🟩
hello_world.test.w -t sim 743ms±8.22 665ms±6.36 -78ms (-10.45%)🟩
hello_world.test.w -t tf-aws 6105ms±49.85 5497ms±40.48 -608ms (-9.96%)🟩
empty.test.w -t sim 679ms±7.25 619ms±13.43 -60ms (-8.79%)🟩
empty.test.w -t tf-aws 876ms±10.97 779ms±7.22 -97ms (-11.03%)🟩
jsii_small.test.w -t sim 698ms±8.88 623ms±11.67 -75ms (-10.72%)🟩
jsii_small.test.w -t tf-aws 871ms±11.34 785ms±6.69 -85ms (-9.79%)🟩
functions_1.test.w -t sim 776ms±13.39 700ms±12.16 -76ms (-9.82%)🟩
functions_1.test.w -t tf-aws 2723ms±62.36 2448ms±62.21 -275ms (-10.09%)🟩
Last Updated (UTC) 2023-09-29 22:38

@MarkMcCulloh MarkMcCulloh merged commit 65124f1 into main Sep 29, 2023
11 of 12 checks passed
@MarkMcCulloh MarkMcCulloh deleted the revert-4342-rybickic/compile-directory branch September 29, 2023 22:38
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.34.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hasanaburayyan hasanaburayyan hasanaburayyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkMcCulloh @monadabot @hasanaburayyan