Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): compile directories #4348

Merged
merged 5 commits into from
Sep 30, 2023
Merged

feat(cli): compile directories #4348

merged 5 commits into from
Sep 30, 2023

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Sep 29, 2023

Re-roll of #4342 which was reverted due to a regression to windows tests.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@monadabot
Copy link
Contributor

monadabot commented Sep 30, 2023

Console preview environment is available at https://wing-console-pr-4348.fly.dev 🚀

Last Updated (UTC) 2023-09-30 01:12

@monadabot
Copy link
Contributor

monadabot commented Sep 30, 2023

Benchmarks

Results
name mean min max moe sd
version 82ms 79ms 84ms 2ms 3ms
functions_10.test.w -t sim 701ms 683ms 746ms 9ms 17ms
functions_10.test.w -t tf-aws 4254ms 4199ms 4298ms 19ms 34ms
jsii_big.test.w -t sim 3834ms 3790ms 3918ms 20ms 37ms
jsii_big.test.w -t tf-aws 4014ms 3911ms 4171ms 30ms 55ms
hello_world.test.w -t sim 620ms 608ms 641ms 6ms 12ms
hello_world.test.w -t tf-aws 5020ms 4941ms 5103ms 25ms 44ms
empty.test.w -t sim 571ms 561ms 586ms 5ms 9ms
empty.test.w -t tf-aws 713ms 702ms 724ms 5ms 9ms
jsii_small.test.w -t sim 573ms 559ms 595ms 6ms 11ms
jsii_small.test.w -t tf-aws 724ms 704ms 746ms 6ms 11ms
functions_1.test.w -t sim 646ms 634ms 656ms 5ms 8ms
functions_1.test.w -t tf-aws 2204ms 2058ms 2364ms 44ms 79ms
Comparison to main
Benchmark Before After Change
version 83ms±2.44 82ms±2.3 -1ms (-1.39%)🟩
functions_10.test.w -t sim 704ms±7.11 701ms±9.21 -3ms (-0.36%)🟩
functions_10.test.w -t tf-aws 4373ms±36.62 4254ms±19.01 -119ms (-2.72%)🟩
jsii_big.test.w -t sim 3915ms±31.16 3834ms±20.46 -81ms (-2.08%)🟩
jsii_big.test.w -t tf-aws 4017ms±19.54 4014ms±30.49 -3ms (-0.08%)🟩
hello_world.test.w -t sim 630ms±6.87 620ms±6.43 -10ms (-1.67%)🟩
hello_world.test.w -t tf-aws 5094ms±25.13 5020ms±24.55 -75ms (-1.47%)🟩
empty.test.w -t sim 575ms±5.2 571ms±4.76 -5ms (-0.79%)🟩
empty.test.w -t tf-aws 735ms±5.91 713ms±5.14 -22ms (-2.95%)🟩
jsii_small.test.w -t sim 580ms±6.89 573ms±5.89 -7ms (-1.13%)🟩
jsii_small.test.w -t tf-aws 739ms±6.56 724ms±6.24 -15ms (-1.99%)🟩
functions_1.test.w -t sim 663ms±8.66 646ms±4.59 -17ms (-2.59%)🟩
functions_1.test.w -t tf-aws 2257ms±51.33 2204ms±43.58 -52ms (-2.32%)🟩
Last Updated (UTC) 2023-09-30 01:19

@Chriscbr Chriscbr changed the title [WIP] feat(cli): compile directories feat(cli): compile directories Sep 30, 2023
@Chriscbr Chriscbr marked this pull request as ready for review September 30, 2023 01:34
@Chriscbr Chriscbr requested a review from a team as a code owner September 30, 2023 01:34
@mergify
Copy link
Contributor

mergify bot commented Sep 30, 2023

Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if rybickic/compile-directory2 is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 602c8e5 into main Sep 30, 2023
23 of 25 checks passed
@mergify mergify bot deleted the rybickic/compile-directory2 branch September 30, 2023 07:57
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.34.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants