Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: possible conflicting versions of "constructs" package for ts framework #5587

Merged
merged 5 commits into from
Feb 6, 2024

Conversation

MarkMcCulloh
Copy link
Contributor

Just avoid ts framework relying on its own version of constructs

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@MarkMcCulloh MarkMcCulloh requested a review from a team as a code owner January 31, 2024 17:12
@monadabot
Copy link
Contributor

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @eladb
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @skorfmann
Wing Playground @eladcon

@monadabot
Copy link
Contributor

monadabot commented Jan 31, 2024

Console preview environment is available at https://wing-console-pr-5587.fly.dev 🚀

Last Updated (UTC) 2024-02-06 22:22

@monadabot
Copy link
Contributor

monadabot commented Jan 31, 2024

Benchmarks

Comparison to Baseline ⬜⬜⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 57ms±0.51 59ms±0.9 +1ms (+2.54%)⬜
empty.test.w -t sim 477ms±23.77 476ms±24.02 -1ms (-0.2%)⬜
empty.test.w -t tf-aws 566ms±6.03 568ms±5.93 +2ms (+0.31%)⬜
jsii_small.test.w -t sim 466ms±4.42 476ms±4.37 +10ms (+2.1%)🟥
jsii_small.test.w -t tf-aws 570ms±5.8 572ms±4.86 +3ms (+0.5%)⬜
hello_world.test.w -t sim 510ms±8.18 506ms±5.88 -4ms (-0.72%)⬜
hello_world.test.w -t tf-aws 1272ms±5.74 1270ms±7.5 -2ms (-0.14%)⬜
jsii_big.test.w -t sim 3321ms±98.74 3259ms±12.93 -63ms (-1.88%)⬜
jsii_big.test.w -t tf-aws 3350ms±20.72 3361ms±15.7 +11ms (+0.34%)⬜
functions_10.test.w -t sim 603ms±7.71 603ms±5.67 0ms (-0.01%)⬜
functions_10.test.w -t tf-aws 2066ms±6.79 2078ms±14.18 +12ms (+0.58%)⬜
functions_1.test.w -t sim 499ms±4.41 501ms±4.85 +2ms (+0.42%)⬜
functions_1.test.w -t tf-aws 793ms±6.07 798ms±6.38 +5ms (+0.61%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 59ms 58ms 62ms 1ms 1ms
empty.test.w -t sim 476ms 459ms 571ms 24ms 34ms
empty.test.w -t tf-aws 568ms 553ms 584ms 6ms 8ms
jsii_small.test.w -t sim 476ms 466ms 484ms 4ms 6ms
jsii_small.test.w -t tf-aws 572ms 563ms 584ms 5ms 7ms
hello_world.test.w -t sim 506ms 497ms 525ms 6ms 8ms
hello_world.test.w -t tf-aws 1270ms 1252ms 1285ms 8ms 10ms
jsii_big.test.w -t sim 3259ms 3230ms 3293ms 13ms 18ms
jsii_big.test.w -t tf-aws 3361ms 3326ms 3396ms 16ms 22ms
functions_10.test.w -t sim 603ms 588ms 614ms 6ms 8ms
functions_10.test.w -t tf-aws 2078ms 2039ms 2110ms 14ms 20ms
functions_1.test.w -t sim 501ms 486ms 509ms 5ms 7ms
functions_1.test.w -t tf-aws 798ms 786ms 815ms 6ms 9ms
Last Updated (UTC) 2024-02-06 22:27

Copy link
Contributor

mergify bot commented Feb 6, 2024

Thanks for contributing, @MarkMcCulloh! This PR will now be added to the merge queue, or immediately merged if mark/ts-construct is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 8afc22e into main Feb 6, 2024
13 checks passed
@mergify mergify bot deleted the mark/ts-construct branch February 6, 2024 22:28
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.57.8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants