Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): jsii type system compatibility with wing type system and test jsii struct imports #6082

Merged
merged 8 commits into from
Mar 28, 2024

Conversation

yoav-steinberg
Copy link
Contributor

Closes #479

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

@yoav-steinberg yoav-steinberg requested a review from a team as a code owner March 28, 2024 09:37
Copy link

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@yoav-steinberg yoav-steinberg changed the title chore(docs): jsii type system compatibiliry with wing type system and test jsii struct imports chore(docs): jsii type system compatibility with wing type system and test jsii struct imports Mar 28, 2024
docs/docs/03-language-reference.md Outdated Show resolved Hide resolved
yoav-steinberg and others added 3 commits March 28, 2024 11:44
Co-authored-by: Uri Bar <106860404+staycoolcall911@users.noreply.github.com>
@monadabot
Copy link
Contributor

monadabot commented Mar 28, 2024

Benchmarks

Comparison to Baseline 🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 57ms±0.52 60ms±0.63 +2ms (+3.8%)🟥
empty.test.w -t sim 366ms±26.52 357ms±3.44 -9ms (-2.45%)⬜
empty.test.w -t tf-aws 590ms±7.47 596ms±6.01 +6ms (+1.08%)⬜
hello_world.test.w -t sim 383ms±3.66 394ms±5.34 +11ms (+2.8%)⬜
hello_world.test.w -t tf-aws 1523ms±16.03 1536ms±24.72 +13ms (+0.86%)⬜
functions_10.test.w -t sim 460ms±4.2 458ms±9.99 -2ms (-0.43%)⬜
functions_10.test.w -t tf-aws 2094ms±16.47 2114ms±17.35 +20ms (+0.98%)⬜
jsii_small.test.w -t sim 355ms±4.54 359ms±2.49 +4ms (+1.07%)⬜
jsii_small.test.w -t tf-aws 590ms±4.27 593ms±4.17 +3ms (+0.44%)⬜
jsii_big.test.w -t sim 2772ms±18.45 2764ms±8 -8ms (-0.29%)⬜
jsii_big.test.w -t tf-aws 3007ms±13.55 2982ms±11.64 -25ms (-0.82%)⬜
functions_1.test.w -t sim 387ms±3.38 385ms±4.39 -2ms (-0.41%)⬜
functions_1.test.w -t tf-aws 826ms±4.96 816ms±4.16 -10ms (-1.22%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 60ms 58ms 61ms 1ms 1ms
empty.test.w -t sim 357ms 351ms 364ms 3ms 5ms
empty.test.w -t tf-aws 596ms 586ms 609ms 6ms 8ms
hello_world.test.w -t sim 394ms 384ms 410ms 5ms 7ms
hello_world.test.w -t tf-aws 1536ms 1501ms 1629ms 25ms 35ms
functions_10.test.w -t sim 458ms 437ms 478ms 10ms 14ms
functions_10.test.w -t tf-aws 2114ms 2093ms 2153ms 17ms 24ms
jsii_small.test.w -t sim 359ms 351ms 364ms 2ms 3ms
jsii_small.test.w -t tf-aws 593ms 582ms 599ms 4ms 6ms
jsii_big.test.w -t sim 2764ms 2745ms 2779ms 8ms 11ms
jsii_big.test.w -t tf-aws 2982ms 2959ms 3002ms 12ms 16ms
functions_1.test.w -t sim 385ms 379ms 394ms 4ms 6ms
functions_1.test.w -t tf-aws 816ms 808ms 825ms 4ms 6ms
Last Updated (UTC) 2024-03-28 10:09

@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Mar 28, 2024
@yoav-steinberg yoav-steinberg removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Mar 28, 2024
Copy link
Contributor

mergify bot commented Mar 28, 2024

Thanks for contributing, @yoav-steinberg! This PR will now be added to the merge queue, or immediately merged if yoav/jsii_struct_test is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 4e7b0d2 into main Mar 28, 2024
15 checks passed
@mergify mergify bot deleted the yoav/jsii_struct_test branch March 28, 2024 10:10
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.66.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spec: need to document our usage of structs as part of our integration with jsii
3 participants