Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk)!: sunset ex.ReactApp #6179

Merged
merged 5 commits into from
Apr 9, 2024
Merged

feat(sdk)!: sunset ex.ReactApp #6179

merged 5 commits into from
Apr 9, 2024

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Apr 9, 2024

The Wing library ecosystem is steadily growing, and we now have a dedicated winglib for React, which you can use with:

bring react;

Huge thanks to @meirdev for contributing this winglib!
It supports both the sim and tf-aws targets. To lighten our maintenance load (and build times), this PR removes the built-in ex.ReactApp class from the core Wing SDK.

Closes #6139

There is a known limitation that the react winglib does not yet support customizing the domain on AWS using cloud.Domain - see #6178. (contributions are welcome!)

If you have any trouble with the dedicated winglib, please let us know by opening a GitHub issue or sending a message on the Wing slack - we're happy to help.

BREAKING CHANGE: ex.ReactApp and related types have been removed from the Wing SDK. We recommend using the dedicated react winglib instead.

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Copy link

github-actions bot commented Apr 9, 2024

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic Owner
Wing SDK and utility APIs @chriscbr
Wing Console @ainvoner, @skyrpex, @polamoros
JSON, structs, primitives and collections @hasanaburayyan
Platforms and plugins @hasanaburayyan
Frontend resources (website, react, etc) @tsuf239
Language design @chriscbr
VSCode extension and language server @markmcculloh
Compiler architecture, inflights, lifting @yoav-steinberg
Wing Testing Framework @tsuf239
Wing CLI @markmcculloh
Build system, dev environment, releases @markmcculloh
Library Ecosystem @chriscbr
Documentation @hasanaburayyan
SDK test suite @tsuf239
Examples @hasanaburayyan
Wing Playground @eladcon

@Chriscbr Chriscbr changed the title feat(sdk)!: sunset ex.ReactApp feat(sdk)!: sunset ex.ReactApp Apr 9, 2024
@monadabot
Copy link
Contributor

monadabot commented Apr 9, 2024

Console preview environment is available at https://wing-console-pr-6179.fly.dev 🚀

Last Updated (UTC) 2024-04-09 21:54

@monadabot
Copy link
Contributor

monadabot commented Apr 9, 2024

Benchmarks

Comparison to Baseline ⬜⬜🟥⬜⬜⬜⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 58ms±0.63 59ms±1.1 +1ms (+2.15%)⬜
functions_1.test.w -t sim 392ms±9.61 390ms±5.18 -2ms (-0.54%)⬜
functions_1.test.w -t tf-aws 822ms±3.59 842ms±8.56 +20ms (+2.47%)🟥
hello_world.test.w -t sim 390ms±9.33 397ms±10.85 +7ms (+1.84%)⬜
hello_world.test.w -t tf-aws 1513ms±10.19 1511ms±15.64 -2ms (-0.11%)⬜
jsii_big.test.w -t sim 2774ms±12.43 2793ms±12.43 +20ms (+0.7%)⬜
jsii_big.test.w -t tf-aws 2989ms±20.31 3006ms±10.1 +17ms (+0.56%)⬜
functions_10.test.w -t sim 473ms±9.8 475ms±6.95 +3ms (+0.57%)⬜
functions_10.test.w -t tf-aws 2119ms±13.76 2134ms±7.51 +15ms (+0.73%)⬜
jsii_small.test.w -t sim 359ms±2.06 363ms±5.7 +4ms (+1.25%)⬜
jsii_small.test.w -t tf-aws 597ms±5.15 599ms±5.03 +3ms (+0.43%)⬜
empty.test.w -t sim 352ms±4.32 356ms±4.49 +4ms (+1.25%)⬜
empty.test.w -t tf-aws 588ms±4.02 591ms±4.82 +3ms (+0.59%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 59ms 58ms 63ms 1ms 2ms
functions_1.test.w -t sim 390ms 374ms 397ms 5ms 7ms
functions_1.test.w -t tf-aws 842ms 823ms 860ms 9ms 12ms
hello_world.test.w -t sim 397ms 383ms 437ms 11ms 15ms
hello_world.test.w -t tf-aws 1511ms 1490ms 1569ms 16ms 22ms
jsii_big.test.w -t sim 2793ms 2768ms 2822ms 12ms 17ms
jsii_big.test.w -t tf-aws 3006ms 2979ms 3028ms 10ms 14ms
functions_10.test.w -t sim 475ms 460ms 490ms 7ms 10ms
functions_10.test.w -t tf-aws 2134ms 2116ms 2153ms 8ms 11ms
jsii_small.test.w -t sim 363ms 350ms 377ms 6ms 8ms
jsii_small.test.w -t tf-aws 599ms 587ms 609ms 5ms 7ms
empty.test.w -t sim 356ms 344ms 362ms 4ms 6ms
empty.test.w -t tf-aws 591ms 582ms 601ms 5ms 7ms
Last Updated (UTC) 2024-04-09 22:00

monadabot and others added 2 commits April 9, 2024 10:34
@monadabot monadabot added the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 9, 2024
@Chriscbr Chriscbr removed the ⚠️ pr/review-mutation PR has been mutated and will not auto-merge. Clear this label if the changes look good! label Apr 9, 2024
Copy link
Contributor

mergify bot commented Apr 9, 2024

Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if rybickic/sunset-react is up-to-date with main and the queue is empty.

Copy link
Contributor

mergify bot commented Apr 9, 2024

Thanks for contributing, @Chriscbr! This PR will now be added to the merge queue, or immediately merged if rybickic/sunset-react is up-to-date with main and the queue is empty.

@mergify mergify bot merged commit 6bd05c6 into main Apr 9, 2024
15 checks passed
@mergify mergify bot deleted the rybickic/sunset-react branch April 9, 2024 22:01
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.68.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate ex.ReactApp to @winglibs/reactapp
4 participants