fix(compiler)!: no way to detect if an interface implements a preflight class #6197

yoav-steinberg · 2024-04-10T10:44:33Z

Add a phase modifier inflight support to interface definitions. Now all preflight interfaces implicitly implement std.IResouce the same way that prefligth classes implicitly implement std.Resource. We can now explicitly qualify these interfaces with the lift() builtin and we can get qualification errors if an inflight variable is being used to access such an object (same as classes).

Note that inflight interfaces can be defined preflight with the keywork and all their methods will be implicitly inflight. Interfaces defined inflight are always inflight interfaces. Preflight interfaces may extend inflight interfaces, but not the other way around.

JSII imported interfaces are, at least for now, always preflight interfaces.

Breaking change:
Since inflight interfaces are new, code using interfaces in inflight that were defined in preflight scope will need to add the inflight modifier to those interfaces or the compiler will complain that you're trying to access an unknown preflight object:

inflight IMyIface { // Explicitly mark this interface as inflight so it can be used in inflight code without worrying about lifting
  do(): void; // No need to specify `do` is an inflight method, it's implicit from the interface type.
}
inflight () => {
  x: IMyIface = ....;
  x.do(); // This would be a qualification error without the above fix.
}

Other fixes

Fixed span in diagnostic of wrongly typed methods implementing an interface, previously the span pointed to the implementing class instead of the specific method inside that class that mismatches the interface definition.
Cleaned up some dead code.

Checklist

Title matches Winglang's style guide
Description explains motivation and solution
Tests added (always)
Docs updated (only required for features)
Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

github-actions · 2024-04-10T10:44:44Z

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistence, don't hesitate to ping the relevant owner over Slack.

Topic	Owner
Wing SDK and utility APIs	`@chriscbr`
Wing Console	`@ainvoner`, `@skyrpex`, `@polamoros`
JSON, structs, primitives and collections	`@hasanaburayyan`
Platforms and plugins	`@hasanaburayyan`
Frontend resources (website, react, etc)	`@tsuf239`
Language design	`@chriscbr`
VSCode extension and language server	`@markmcculloh`
Compiler architecture, inflights, lifting	`@yoav-steinberg`
Wing Testing Framework	`@tsuf239`
Wing CLI	`@markmcculloh`
Build system, dev environment, releases	`@markmcculloh`
Library Ecosystem	`@chriscbr`
Documentation	`@hasanaburayyan`
SDK test suite	`@tsuf239`
Examples	`@hasanaburayyan`
Wing Playground	`@eladcon`

monadabot · 2024-04-10T10:51:47Z

Console preview environment is available at https://wing-console-pr-6197.fly.dev 🚀

Last Updated (UTC) 2024-04-12 06:27

monadabot · 2024-04-10T10:57:01Z

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜⬜🟥⬜⬜⬜

Benchmark	Before	After	Change
version	59ms±0.6	60ms±0.52	+1ms (+1.66%)⬜
functions_1.test.w -t sim	388ms±4.2	396ms±3.83	+7ms (+1.91%)⬜
functions_1.test.w -t tf-aws	834ms±6.38	844ms±9.74	+11ms (+1.28%)⬜
hello_world.test.w -t sim	392ms±5.71	398ms±7.62	+6ms (+1.62%)⬜
hello_world.test.w -t tf-aws	1524ms±18.89	1533ms±13.4	+9ms (+0.6%)⬜
jsii_big.test.w -t sim	2803ms±11.59	2815ms±14.44	+12ms (+0.44%)⬜
jsii_big.test.w -t tf-aws	3022ms±7.38	3026ms±14.53	+4ms (+0.12%)⬜
functions_10.test.w -t sim	477ms±11.05	483ms±10.75	+6ms (+1.17%)⬜
functions_10.test.w -t tf-aws	2159ms±12.41	2172ms±11.6	+12ms (+0.57%)⬜
jsii_small.test.w -t sim	363ms±2.42	371ms±3.55	+8ms (+2.11%)🟥
jsii_small.test.w -t tf-aws	602ms±5.24	611ms±5.13	+9ms (+1.45%)⬜
empty.test.w -t sim	356ms±3.07	363ms±4.74	+7ms (+2%)⬜
empty.test.w -t tf-aws	593ms±3.18	602ms±6.79	+9ms (+1.43%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results

name	mean	min	max	moe	sd
version	60ms	59ms	61ms	1ms	1ms
functions_1.test.w -t sim	396ms	387ms	403ms	4ms	5ms
functions_1.test.w -t tf-aws	844ms	829ms	875ms	10ms	14ms
hello_world.test.w -t sim	398ms	387ms	426ms	8ms	11ms
hello_world.test.w -t tf-aws	1533ms	1512ms	1582ms	13ms	19ms
jsii_big.test.w -t sim	2815ms	2793ms	2850ms	14ms	20ms
jsii_big.test.w -t tf-aws	3026ms	2996ms	3059ms	15ms	20ms
functions_10.test.w -t sim	483ms	460ms	499ms	11ms	15ms
functions_10.test.w -t tf-aws	2172ms	2151ms	2195ms	12ms	16ms
jsii_small.test.w -t sim	371ms	363ms	378ms	4ms	5ms
jsii_small.test.w -t tf-aws	611ms	600ms	623ms	5ms	7ms
empty.test.w -t sim	363ms	354ms	377ms	5ms	7ms
empty.test.w -t tf-aws	602ms	589ms	616ms	7ms	10ms