-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console): wing console application reset capability #6665
feat(console): wing console application reset capability #6665
Conversation
Thanks for opening this pull request! 🎉
|
Console preview environment is available at https://wing-console-pr-6665.fly.dev 🚀 Last Updated (UTC) 2024-06-14 08:50 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@polamoros I am not a fan of the new header.
I think the "RESET" button should be on the top right of the map view:
And it should just say "Reset".
When clicking on it, there should be a message box:
Are you sure you want to reset all state and restart the application?
YES/NO
The Discord button can stay on the footer AFAIK for now.
I don't like the header either. Regarding moving the reset button to the map controls, I don't think it's the correct solution. We are restarting the application, not just the map. Regarding the Discord button, @ainvoner wants to place it in a more visible location. |
It doesn't make sense to me to have such a functionality inside the map view: the reset action affects the whole application, not just the map view. Also, it may signal to the users that it only resets the view (same as the [] button on the right side). Even if a new header is almost empty, it makes sense to place the reset button there IMO. |
We could also merge the functionality of the reset button and the Status label. They are similar. |
It's strange that the Status label isn't updated when the app is restarting 🤔 |
I think the restart button should be also disabled when the simulator is loading (e.g. after editing the wing file). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Cristian Pallarés <cristianp@wing.cloud>
Co-authored-by: Cristian Pallarés <cristianp@wing.cloud>
Co-authored-by: Cristian Pallarés <cristianp@wing.cloud>
Co-authored-by: Cristian Pallarés <cristianp@wing.cloud>
Thanks for contributing, @polamoros! This PR will now be added to the merge queue, or immediately merged if |
…e-application-reset-capability
Thanks for contributing, @polamoros! This PR will now be added to the merge queue, or immediately merged if |
Congrats! 🚀 This was released in Wing 0.74.60. |
Resolves #6124