Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): remove lodash.once in favor of custom implementation #6979

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

skyrpex
Copy link
Contributor

@skyrpex skyrpex commented Aug 2, 2024

No description provided.

@skyrpex skyrpex requested a review from a team as a code owner August 2, 2024 09:29
Copy link

github-actions bot commented Aug 2, 2024

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜🟥⬜⬜⬜⬜⬜⬜⬜
Benchmark Before After Change
version 58ms±1.1 58ms±0.5 0ms (-0.67%)⬜
empty.test.w -t sim 376ms±22.39 372ms±4.91 -5ms (-1.24%)⬜
empty.test.w -t tf-aws 616ms±7.68 621ms±4.56 +4ms (+0.69%)⬜
hello_world.test.w -t sim 411ms±9.97 410ms±5.04 0ms (-0.04%)⬜
hello_world.test.w -t tf-aws 1495ms±10.59 1514ms±13.15 +19ms (+1.24%)⬜
jsii_small.test.w -t sim 373ms±2.64 385ms±3.77 +12ms (+3.32%)🟥
jsii_small.test.w -t tf-aws 620ms±5.76 631ms±5.36 +10ms (+1.63%)⬜
jsii_big.test.w -t sim 2954ms±32.23 3005ms±17.16 +51ms (+1.72%)⬜
jsii_big.test.w -t tf-aws 3171ms±12.98 3181ms±12.67 +10ms (+0.31%)⬜
functions_1.test.w -t sim 410ms±3.64 408ms±7.83 -2ms (-0.53%)⬜
functions_1.test.w -t tf-aws 867ms±8.29 856ms±4.34 -11ms (-1.26%)⬜
functions_10.test.w -t sim 516ms±8.68 512ms±10.58 -4ms (-0.79%)⬜
functions_10.test.w -t tf-aws 2237ms±13.76 2214ms±22.99 -23ms (-1.03%)⬜

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 58ms 57ms 59ms 1ms 1ms
empty.test.w -t sim 372ms 362ms 386ms 5ms 7ms
empty.test.w -t tf-aws 621ms 607ms 627ms 5ms 6ms
hello_world.test.w -t sim 410ms 397ms 418ms 5ms 7ms
hello_world.test.w -t tf-aws 1514ms 1492ms 1544ms 13ms 18ms
jsii_small.test.w -t sim 385ms 377ms 393ms 4ms 5ms
jsii_small.test.w -t tf-aws 631ms 615ms 639ms 5ms 7ms
jsii_big.test.w -t sim 3005ms 2968ms 3037ms 17ms 24ms
jsii_big.test.w -t tf-aws 3181ms 3162ms 3210ms 13ms 18ms
functions_1.test.w -t sim 408ms 394ms 436ms 8ms 11ms
functions_1.test.w -t tf-aws 856ms 846ms 867ms 4ms 6ms
functions_10.test.w -t sim 512ms 496ms 534ms 11ms 15ms
functions_10.test.w -t tf-aws 2214ms 2148ms 2268ms 23ms 32ms
Last Updated (UTC) 2024-08-02 09:39

@skyrpex skyrpex merged commit 524796c into main Aug 2, 2024
14 checks passed
@skyrpex skyrpex deleted the remove-lodash-once branch August 2, 2024 12:06
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.80.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants