Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix references to dist/ folder in turbo.json #7070

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Sep 3, 2024

Checklist

  • Title matches Winglang's style guide
  • Description explains motivation and solution
  • Tests added (always)
  • Docs updated (only required for features)
  • Added pr/e2e-full label if this feature requires end-to-end testing

By submitting this pull request, I confirm that my contribution is made under the terms of the Wing Cloud Contribution License.

Copy link

github-actions bot commented Sep 3, 2024

Thanks for opening this pull request! 🎉
Please consult the contributing guidelines for details on how to contribute to this project.
If you need any assistance, don't hesitate to ping the relevant owner over Discord.

Topic Owner
Wing SDK and standard library @chriscbr
Wing Console @skyrpex
Wing compiler and language design @chriscbr
VSCode extension and language server @chriscbr
Wing CLI @chriscbr
Documentation @boyney123
Examples @boyney123
Wing Playground @skyrpex

@monadabot
Copy link
Contributor

Console preview environment is available at https://wing-console-pr-7070.fly.dev 🚀

Last Updated (UTC) 2024-09-03 20:08

@monadabot
Copy link
Contributor

Benchmarks

Comparison to Baseline ⬜⬜⬜⬜⬜⬜⬜⬜🟥⬜⬜⬜🟥
Benchmark Before After Change
version 57ms±0.56 56ms±0.45 -1ms (-1.52%)⬜
hello_world.test.w -t sim 426ms±16.05 409ms±3.14 -17ms (-3.96%)⬜
hello_world.test.w -t tf-aws 1496ms±11.78 1500ms±12.35 +3ms (+0.23%)⬜
jsii_big.test.w -t sim 2967ms±21.18 3009ms±50.98 +42ms (+1.43%)⬜
jsii_big.test.w -t tf-aws 3166ms±11.44 3183ms±18.48 +17ms (+0.53%)⬜
functions_1.test.w -t sim 405ms±4.45 407ms±4.16 +2ms (+0.41%)⬜
functions_1.test.w -t tf-aws 839ms±1.73 856ms±3.56 +17ms (+1.97%)⬜
empty.test.w -t sim 369ms±3.31 369ms±3.49 0ms (-0.08%)⬜
empty.test.w -t tf-aws 598ms±4.24 618ms±3.82 +20ms (+3.32%)🟥
functions_10.test.w -t sim 494ms±18.15 504ms±8.98 +11ms (+2.18%)⬜
functions_10.test.w -t tf-aws 2171ms±17.38 2186ms±13 +15ms (+0.7%)⬜
jsii_small.test.w -t sim 384ms±5.82 379ms±3.34 -5ms (-1.41%)⬜
jsii_small.test.w -t tf-aws 606ms±4.91 625ms±4.41 +19ms (+3.17%)🟥

⬜ Within 1.5 standard deviations
🟩 Faster, Above 1.5 standard deviations
🟥 Slower, Above 1.5 standard deviations

Benchmarks may vary outside of normal expectations, especially when running in GitHub Actions CI.

Results
name mean min max moe sd
version 56ms 56ms 57ms 0ms 1ms
hello_world.test.w -t sim 409ms 400ms 417ms 3ms 4ms
hello_world.test.w -t tf-aws 1500ms 1477ms 1539ms 12ms 17ms
jsii_big.test.w -t sim 3009ms 2960ms 3195ms 51ms 71ms
jsii_big.test.w -t tf-aws 3183ms 3150ms 3243ms 18ms 26ms
functions_1.test.w -t sim 407ms 400ms 417ms 4ms 6ms
functions_1.test.w -t tf-aws 856ms 846ms 860ms 4ms 5ms
empty.test.w -t sim 369ms 360ms 376ms 3ms 5ms
empty.test.w -t tf-aws 618ms 609ms 628ms 4ms 5ms
functions_10.test.w -t sim 504ms 487ms 525ms 9ms 13ms
functions_10.test.w -t tf-aws 2186ms 2163ms 2224ms 13ms 18ms
jsii_small.test.w -t sim 379ms 373ms 386ms 3ms 5ms
jsii_small.test.w -t tf-aws 625ms 619ms 639ms 4ms 6ms
Last Updated (UTC) 2024-09-03 20:13

@Chriscbr Chriscbr merged commit 030f393 into main Sep 3, 2024
14 checks passed
@Chriscbr Chriscbr deleted the rybickic/fix-dist-references branch September 3, 2024 20:19
@monadabot
Copy link
Contributor

Congrats! 🚀 This was released in Wing 0.83.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants