Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots of unmerged pull reqs!? #49

Closed
linas opened this issue Aug 31, 2021 · 4 comments
Closed

Lots of unmerged pull reqs!? #49

linas opened this issue Aug 31, 2021 · 4 comments

Comments

@linas
Copy link

linas commented Aug 31, 2021

Why are there so many unmerged pull reqs? Is this project unmaintained? Deprecated in favor of something else?

I've got something else that has a dependency on fibers, and since this project has the smell of bit-rot and broken-ness, I'm thinking perhaps the fibers should be ripped out and replaced by something that works? What's the recommendation going forward into the future?

@aconchillo
Copy link
Collaborator

Hi @linas ! I think fibers is usable as is. I believe that @wingo hasn't had much time to work on it. At one point I was given commit access because of this #27 and since then I have merged very basic MRs, mostly documentation and trivial bug fixes, but not many lately to be fair.

I don't think there are that many pull requests to merge, from the 8, two of them are support for FreeBSD and support for libevent (which I helped with last year), so that leaves as with 6.

Anyway, not trying to justify anyone here, just saying that fibers can be used as is (e.g. see latest stis-engine).

I think and hope that I will finally have time to start working back on Guile related projects soon and one of the things I wanted to finish is the libevent support changes @wingo suggested.

There's also this project: https://www.gnu.org/software/8sync/ from @cwebber

@linas
Copy link
Author

linas commented Aug 31, 2021

Ah. I'm not using fibers directly; I'm currently trying to install an utterly unrelated project that has a dependency on a forked and patched version of this repo. I'm trying to figure out whether I should encourage the maintainers there to remove dependencies on this package. I'm big into the idea of code that isn't fragile, that doesn't have dependencies on weird packages, that is easy to build, maintain. That usually means removing dependencies on anything half-baked or incomplete. I mean, experimentation is great. Just that ... well ... I'm just trying to get a simple unrelated short task done, (the proverbial "Its easy, it'll take an afternoon") and am wandering off into a long detour, visiting foreign lands.

@linas
Copy link
Author

linas commented Aug 31, 2021

I mean, anyway, thanks. I strongly encourage either merging pull reqs, or closing them. That helps people like me from having to figure out why I'm supposed to use someone-else's patched version (which BTW, doesn't seem to have a corresponding pull req here.)

@aconchillo
Copy link
Collaborator

I understand. As I said I'll do my best to get back to it soon and hopefully be able to move this forward. I'm closing this issue for now. Feel free to reopen it in a few months if things don't improve 😅 . Good luck with your project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants