Freebsd 20190619 #27
Closed
Freebsd 20190619 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 19, 2019 23:26
+ autoconf checks presence of kqueue (freebsd) and uses that interface instead of epoll. Effectively choosing kqueue.c file instead of epoll.c Both C files shares alot of overall structure, but it seems easier to have them separated (prioritize development over maintainability for now). + m4-local directory holding m4 macros Try to anticipate a future which holds alot of m4 macros. Currently kqueue.m4 is placed there which tries to detect kqueue(2) freebsd interface. + An "extfilename" variable name is setup in Makefile.am that is then feed to fibers/config.scm.in. This determines what compiled library/extension to load (epoll.so or kqueue.so).
kqueue implementation, which emulate an epoll interface towards guile.
+ setup a template scheme file, just like fibers/config.scm.in, but select what template to use depending on the operating-system. + No support for affinity on freebsd for now, stub it up.
The clock_id argument to clock_nanosleep differs between linux and freebsd. Unfortunately on freebsd, we must use CLOCK_MONOTONIC instead of threads-clockid, which linux uses. Probably no performance difference, but it splits the code.
Some quick notes scribbled into fibers.texi
|
I was interested in running fibers in OS X and was going to stat working on the kqueue port. This work is great! @wingo any chance to get it merged? |
|
Certainly :) Aleix you are now a collaborator, feel free to merge when it looks good to you. It all looked fine to me at a first glance but since you're available to test and such, I leave the review and merge to you :) |
|
@wingo sounds good. thanks! i'm taking a look at other PRs as well. i'm not yet super familiar with everything but planning to dig into it and fix the opened issues. |
|
I think this should probably be closed in favor of #42. |
And are you going to? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for freebsd12.