Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gtk-sharp #24

Closed
smorar opened this issue Mar 13, 2016 · 6 comments
Closed

Add support for gtk-sharp #24

smorar opened this issue Mar 13, 2016 · 6 comments

Comments

@smorar
Copy link

smorar commented Mar 13, 2016

Currently, gtk-sharp is not included in the build script.

@nacho
Copy link
Contributor

nacho commented Mar 13, 2016

@smorar feeling like providing a patch?

@smorar
Copy link
Author

smorar commented Mar 14, 2016

@nacho, I would love to. Currently stuck on how to generate code from the
*-api.xml files.

-S

On 14 March 2016 at 02:46, Ignacio Casal Quinteiro <notifications@github.com

wrote:

@smorar https://github.com/smorar feeling like providing a patch?


Reply to this email directly or view it on GitHub
#24 (comment).

@nacho
Copy link
Contributor

nacho commented Apr 27, 2016

I checked and gtk-sharp does not use visual studio nor cmake nor nmake to build the libraries, so I doubt we will be able to add this project anytime soon.

@smorar
Copy link
Author

smorar commented Apr 27, 2016

@nacho, thank you for looking into supporting gtk-sharp.

I have done some work on this problem, and have managed to build gtk-sharp manually using visual studio. I have step-by-step instructions here:
https://docs.google.com/document/d/1374Pi6QJXdejM6mId1S3GBT-I2WMTqBtkhVfw0ZKhGA

A couple of issues that I'd need resolved before I can pull a patch together:

  • Is it feasible to store the gtk-sharp visual studio files in the wingtk repository, while linking / downloading a specific repository version?
  • I need to figure out how to patch the original source using the wingtk build script
  • I need to figure out how to build and run the gapi-fixup and generator tools at the appropriate step in the build process using the wingtk build script

@nacho
Copy link
Contributor

nacho commented Apr 27, 2016

@smorar that's great.
See that I made a fork of my own for gtk-sharp too and I am trying to get some contacts with upstream to get the patches upstream. https://github.com/nacho/gtk-sharp

For the visual studio projects: I would like to see an approach as for i.e gtk+. Having all the visual studio projects in build/win32/vsVer. We could make also a gtk-sharp fork in the wingtk org so we get first the patches there and then we request them upstream.

@smorar
Copy link
Author

smorar commented Apr 27, 2016

I ended up using the openmedicus gtk-sharp fork, as it has been updated to support more recent gtk versions than upstream. So, until upstream supports gtk > 3.18, I'd recommend following this fork.

However, I haven't actually checked to see whether anything is broken when compiling against 3.18 in upstream.

@danyeaw danyeaw changed the title feature request - add support for gtk-sharp Add support for gtk-sharp Nov 26, 2021
@pbor pbor closed this as completed May 27, 2023
step-security-bot pushed a commit to step-security-bot/gvsbuild that referenced this issue Jun 5, 2024
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.22.4 to 2.22.5.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](github/codeql-action@49abf0b...74483a3)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants