Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to vanilla 3.46.0, add math functions and geopoly #5

Closed
wants to merge 3 commits into from

Conversation

ZmotriN
Copy link

@ZmotriN ZmotriN commented May 22, 2024

No description provided.

@ZmotriN ZmotriN changed the title Update to vanilla 3.45.3, add math function and geopoly Update to vanilla 3.45.3, add math functions and geopoly May 22, 2024
@ZmotriN ZmotriN changed the title Update to vanilla 3.45.3, add math functions and geopoly Update to vanilla 3.46.0, add math functions and geopoly May 23, 2024
@cmb69
Copy link
Contributor

cmb69 commented Jul 15, 2024

Thank you for the PR! Updating to SQLite 3.46.0 (which is the most recent release) should be a no-brainer, but I'm not sure about the compile time flags. SQLITE_ENABLE_MATH_FUNCTIONS probably makes sense, especially if these are already included by the build system. SQLITE_ENABLE_GEOPOLY appears to be somewhat special. Unless this extension is already enabled for the builds, it might be good to open an issue for https://github.com/php/php-src. After all, this repository is primarily targeted at providing Windows libraries for PHP.

@cmb69
Copy link
Contributor

cmb69 commented Jul 21, 2024

Given that SQLite3 3.46.0 is available now, and that requests for changing the configuration should be filed as https://github.com/php/php-src issues, I'm closing this PR.

@cmb69 cmb69 closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants