Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: add 'unix-connect' protocol #28

Merged
merged 1 commit into from
Dec 19, 2014

Conversation

santigimeno
Copy link
Member

  • Starting with unix-dgram@0.1.0 there is support for using connect in unix
    DGRAM sockets. It allows to have some kind of congestion control via the
    congestion and writable events.
  • This patch adds the unix-connect protocol that uses this functionality. While
    in congestion it enquees the messages. Once in writable mode it flushes the
    queue and keeps sending messages as normal.
  • It avoids problems like the ones described in Getting EWOULDBLOCK | EAGAIN errno bnoordhuis/node-unix-dgram#4.

- Starting with unix-dgram@0.1.0 there is support for using `connect` in unix
  DGRAM sockets. It allows to have some kind of congestion control via the
  `congestion` and `writable` events.
- This patch adds the `unix-connect` protocol that uses this functionality. While
  in congestion it enquees the messages. Once in writable mode it flushes the
  queue and keeps sending messages as normal.
- It avoids problems like the ones described in
  bnoordhuis/node-unix-dgram#4.
@indexzero
Copy link
Member

@julien51 @thurmda ... any thoughts?

@santigimeno
Copy link
Member Author

ping

@@ -281,3 +303,41 @@ Syslog.prototype.connect = function (callback) {

this.socket.connect(this.port, this.host);
};

Syslog.prototype._unix_dgram_connect = function(cb) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

camelCasePlease

@indexzero indexzero merged commit ab69600 into winstonjs:master Dec 19, 2014
@santigimeno
Copy link
Member Author

Thanks!

2014-12-19 12:40 GMT+01:00 Charlie Robbins notifications@github.com:

Merged #28 #28.


Reply to this email directly or view it on GitHub
#28 (comment).

@santigimeno santigimeno deleted the unix-dgram-connect branch December 19, 2014 12:08
@gregoreesmaa gregoreesmaa mentioned this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants