-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support batch mode in HTTP Transport #1970
Comments
I think the maintainers are unlikely to have time to implement this ourselves, but we'd welcome a PR that adds this type of functionality in a clean way. Thanks! |
Hi @DABH, I've a fix available for this issue. Could you please give the needed authorizations to assign, create a branch and provide a PR? |
I think that I did the PR : #1998 |
With my PR, HTTP batch mode is now supported. Logs are sent to the HTTP endpoint when the first of the following batch option is reached:
|
@DABH could you please have a look on the PR? |
@DABH thanks for reviewing and accepting my PR, so now when do you plan to make a new version? Hope it will not take 1 year and a half! |
Yep, we have some other maintainers now, so a release should happen in the near future. Ideally we can fix the child logger / metadata issues that @maverick1872 is taking the lead on, and then we will cut a new release that includes your PR. |
Great ! |
What's the feature?
For performance reason, a
batch
mode should be available on http transport to break the 1 log = 1 request and send http request by configurable batches.What problem is the feature intended to solve?
When using http transport, a request is sent to the http server for every log call. So 100 logs, 100 http requests.
Is the absence of this feature blocking you or your team? If so, how?
Not blocking but it has a bad user experience impact on our web application. We're using winston http transport to collect all our client logs in our backend log file. During page loading, our web application is a little bit verbose in "info" level. We've seen that the http log requests has a direct impact on the load page time (ie disabling http logs made load pagefaster).
Is this feature similar to an existing feature in another tool?
Yes, take a look at winston-splunk-http-transport
Is this a feature you're prepared to implement, with support from us?
That's possible... :)
The text was updated successfully, but these errors were encountered: