Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for http batch support #1998

Merged
merged 5 commits into from
Jan 11, 2022
Merged

Fix for http batch support #1998

merged 5 commits into from
Jan 11, 2022

Conversation

BBE78
Copy link
Contributor

@BBE78 BBE78 commented Dec 24, 2021

No description provided.

@BBE78 BBE78 mentioned this pull request Dec 24, 2021
Closed
fearphage
fearphage requested changes Jan 9, 2022
View reviewed changes
Copy link
Contributor

@fearphage fearphage left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks like several PRs in onen(add editor config, disable constructor in ESLint, test cleanup/rewrite, etc). You should strive to make pull requests as small and focused as possible. Could you separate them and send individual pull requests for each?

@BBE78 BBE78 requested a review from fearphage January 11, 2022 20:21
@BBE78
Copy link
Contributor Author

BBE78 commented Jan 11, 2022

Hi @fearphage, this PR has been cleaned up to remove unnecessary changes for this fix.

DABH
DABH approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@DABH DABH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for including good tests along with the contribution!

docs/transports.md Outdated Show resolved Hide resolved
@DABH DABH merged commit 207a6d2 into winstonjs:master Jan 11, 2022
@BBE78 BBE78 deleted the feature-support-batch-http-transport branch January 15, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DABH DABH DABH approved these changes

@fearphage fearphage Awaiting requested review from fearphage

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BBE78 @fearphage @DABH