Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require the package.json by its full name. #1100

Merged
merged 1 commit into from
Feb 20, 2018
Merged

Require the package.json by its full name. #1100

merged 1 commit into from
Feb 20, 2018

Conversation

mikenikles
Copy link
Contributor

When using Winston with Rollup and rollup-plugin-json, the following error is thrown:

./node_modules/.bin/rollup -c

index.js → lib/bundle.js...
[!] Error: Could not resolve '../package' from node_modules/winston/lib/winston.js
Error: Could not resolve '../package' from node_modules/winston/lib/winston.js

The code change in this PR fixes that and gets one step closer to using Rollup to bundle Winston.

@mikenikles mikenikles mentioned this pull request Oct 15, 2017
Closed
@indexzero indexzero merged commit 1e37cde into winstonjs:master Feb 20, 2018
@indexzero
Copy link
Member

Thank you for your contribution. Improved browser support is on our must haves list for 3.0.0 💯

This was referenced Feb 20, 2018
Closed
Closed
Mizumaki pushed a commit to Mizumaki/winston that referenced this pull request Jun 11, 2020
@indexzero
Require the package.json by its full name. (winstonjs#1100)
bcfc3b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indexzero indexzero indexzero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikenikles @indexzero