Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label matcher stopped working #242

Closed
omarmeky opened this issue Aug 3, 2020 · 8 comments
Closed

Label matcher stopped working #242

omarmeky opened this issue Aug 3, 2020 · 8 comments
Assignees

Comments

@omarmeky
Copy link

omarmeky commented Aug 3, 2020

We use WIP to block PRs based on title terms and labels. For some reason, it suddenly stopped blocking PRs if the matching label is there. We are not sure if this is an issue with WIP, Github, or us (although nothing changed on our end).

Here is our .github/wip.yml file for reference:

- terms:
  - wip
  - Work in progress
  - 🚧
  locations: title
- terms:
  - qa needed
  - data migration
  - need simultaneous merge
  - waiting for code review
  - waiting for page tests
  locations: label_name
@gr2m
Copy link
Collaborator

gr2m commented Aug 3, 2020

Thanks Omar for reporting the issue. I'll try to reproduce the issue and report back, give me a day or two

@gr2m gr2m self-assigned this Aug 4, 2020
@gr2m
Copy link
Collaborator

gr2m commented Aug 4, 2020

it looks like the @CareMessagePlatform does not have a paid plan, which is required in order to utilize the settings. Can you check on https://github.com/marketplace/wip/ if you have a paid plan?

If you cannot pay, no worries, you can add your org to https://github.com/wip/app/blob/master/pro-plan-for-free.js. All revenue is donated to https://p5js.org/, WIP is a non-profit project. It's main purpose is to demonstrate how to build GitHub Apps with Probot

@omarmeky
Copy link
Author

omarmeky commented Aug 4, 2020

So we have a "pro" plan but it's showing $0/month (possibly because of our non-profit status):

image

It seems strange though that it would suddenly stop working 🤔

@gr2m
Copy link
Collaborator

gr2m commented Aug 4, 2020

Yes indeed, this is all very odd. When I see events from that organization, it does not show me that the installation is on the free plan and hence ignores the configuration.

Could you maybe try to cancel the plan and re-enable it?

@gr2m
Copy link
Collaborator

gr2m commented Aug 4, 2020

I've checked my logs again, and it looks like it stopped recognizing your plan on Jul 29 at 10:34:13am Pacific time. Other installations don't seem to be affected.

@omarmeky
Copy link
Author

omarmeky commented Aug 6, 2020

Could you maybe try to cancel the plan and re-enable it?

@danielnc, can you give that a try?

@omarmeky
Copy link
Author

omarmeky commented Aug 7, 2020

Hmm, seems to be working now for new PRs 🤷

Everything looking ok on your end? Should we close this issue?

@gr2m
Copy link
Collaborator

gr2m commented Aug 7, 2020

hmm maybe just a hiccup, sometimes there are GitHub incidents that impact WIP and all the other GitHub Apps:
https://www.githubstatus.com/

Please reopen if the problem reoccurs. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants