Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing to npm #90

Closed
BPScott opened this issue Jun 6, 2018 · 2 comments
Closed

Publishing to npm #90

BPScott opened this issue Jun 6, 2018 · 2 comments

Comments

@BPScott
Copy link

BPScott commented Jun 6, 2018

Hi @gr2m, thanks for the bot.

I noticed from 0a30fc9 that you're no longer publishing this to npm. I was wondering if you would reconsider this stance.

I'm currently in the process of curating a suite of probot apps to use for my company. My aim is that we would have a single probot installation runs multiple apps as per https://probot.github.io/docs/deployment/#combining-apps. This shall help us be in control of our own availability and reduce the complexity of having to admin multiple Github Apps - instead we have a single app that deals with multiple functional aspects.

If you were to continue publishing the wip bot on npm we would be able to self-host and keep up to date with any changes made.

@gr2m
Copy link
Collaborator

gr2m commented Jun 30, 2018

Hey @BPScott, I think that the WIP won’t be that useful as dependency any longer once #94 is shipped. It will have a check built in to see what marketplace plan the user has and check for custom configuration as described in #96 if they are on a paid plan. You can check the code, it’s not all done yet but you’ll get the idea. What do you think?

@BPScott
Copy link
Author

BPScott commented Jul 2, 2018

Hi @gr2m, I agree that publishing to npm (and my consuming of WIP from npm) doesn't gel with your vision for WIP. Thanks for the update, donating to Rails Girls SoC is a fantastic goal.

Gonna close this as any faffing with npm isn't worth the payoff :)

@BPScott BPScott closed this as completed Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants