Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): error handling (WPB-6271) #2522

Merged
merged 7 commits into from
Feb 23, 2024

Conversation

mchenani
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Fixed and refactored the error handling for E2EI

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented Feb 21, 2024

Test Results

2 809 tests   2 680 ✔️  33s ⏱️
   484 suites     129 💤
   484 files           0

Results for commit f8aaec3.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

datadog-wireapp bot commented Feb 21, 2024

Datadog Report

All test runs bae0b60 🔗

2 Total Test Services: 0 Failed, 2 Passed

Test Services
Service Name Failed Known Flaky New Flaky Passed Skipped Wall Time Test Service View
kalium-ios 0 0 0 2680 129 12m 33.01s Link
kalium-jvm 0 0 0 2805 123 8m 43.05s Link

…into release/fix-e2ei-error-handling

# Conflicts:
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/data/client/E2EIClientProvider.kt
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/data/e2ei/E2EIRepository.kt
@codecov-commenter
Copy link

Codecov Report

Attention: 46 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (release/candidate@5f9f8a8). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/candidate    #2522   +/-   ##
====================================================
  Coverage                     ?   58.43%           
  Complexity                   ?       22           
====================================================
  Files                        ?     1172           
  Lines                        ?    45468           
  Branches                     ?     4307           
====================================================
  Hits                         ?    26567           
  Misses                       ?    16966           
  Partials                     ?     1935           
Files Coverage Δ
...um/logic/feature/e2ei/usecase/EnrollE2EIUseCase.kt 97.93% <100.00%> (ø)
...ire/kalium/logic/data/client/E2EIClientProvider.kt 74.35% <71.42%> (ø)
...gic/data/conversation/MLSConversationRepository.kt 82.33% <77.77%> (ø)
...re/kalium/network/api/base/unbound/acme/ACMEApi.kt 30.85% <14.28%> (ø)
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 25.82% <54.16%> (ø)
.../com/wire/kalium/logic/data/e2ei/E2EIRepository.kt 79.16% <68.75%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f9f8a8...7a2d9ac. Read the comment docs.

@mchenani mchenani enabled auto-merge (squash) February 22, 2024 14:32
Copy link
Contributor

@borichellow borichellow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small style suggestion :)

@mchenani mchenani merged commit 630462f into release/candidate Feb 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants