Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(e2ei): error handling in E2EI flow (WPB-6271) #2732

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

AndroidBob
Copy link
Collaborator

@AndroidBob AndroidBob commented Feb 23, 2024

BugWPB-6271 [Android] Fix crashes during enrollment and show proper error details

Cherry pick from the original PR:


⚠️ Conflicts during cherry-pick:
kalium


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Fixed and refactored the error handling for E2EI
Needs releases with:


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. .

@AndroidBob AndroidBob added the cherry-pick PR is cherry-picking changes from another banch label Feb 23, 2024
@AndroidBob
Copy link
Collaborator Author

Build 3278 failed.

Copy link
Contributor

github-actions bot commented Feb 23, 2024

Test Results

827 tests  ±0   827 ✅ ±0   12m 43s ⏱️ -1s
115 suites ±0     0 💤 ±0 
115 files   ±0     0 ❌ ±0 

Results for commit f62c4ed. ± Comparison against base commit 13475d1.

♻️ This comment has been updated with latest results.

@mchenani mchenani changed the title fix(e2ei): error handling (WPB-6271) fix(e2ei): error handling in E2EI flow (WPB-6271) Feb 28, 2024
@AndroidBob
Copy link
Collaborator Author

Build 3359 failed.

@AndroidBob
Copy link
Collaborator Author

Build 3363 failed.

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 43.19%. Comparing base (13475d1) to head (f62c4ed).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2732      +/-   ##
===========================================
- Coverage    43.20%   43.19%   -0.01%     
===========================================
  Files          409      409              
  Lines        13571    13572       +1     
  Branches      2396     2393       -3     
===========================================
  Hits          5863     5863              
- Misses        7022     7023       +1     
  Partials       686      686              
Files Coverage Δ
...roid/ui/settings/devices/DeviceDetailsViewModel.kt 60.36% <ø> (+0.53%) ⬆️
...droid/ui/e2eiEnrollment/E2EIEnrollmentViewModel.kt 0.00% <0.00%> (ø)
.../android/feature/e2ei/GetE2EICertificateUseCase.kt 0.00% <0.00%> (ø)
...tlin/com/wire/android/ui/debug/DebugDataOptions.kt 0.00% <0.00%> (ø)
...d/ui/home/sync/FeatureFlagNotificationViewModel.kt 53.89% <0.00%> (+0.34%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13475d1...f62c4ed. Read the comment docs.

Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

Merged via the queue into develop with commit 6436d82 Feb 29, 2024
14 of 15 checks passed
@AndroidBob
Copy link
Collaborator Author

Build 3393 succeeded.

The build produced the following APK's:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick PR is cherry-picking changes from another banch size/XS
Projects
None yet
4 participants