Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2ei): error handling (WPB-6271) #2721

Merged
merged 8 commits into from Feb 23, 2024
Merged

fix(e2ei): error handling (WPB-6271) #2721

merged 8 commits into from Feb 23, 2024

Conversation

mchenani
Copy link
Member

@mchenani mchenani commented Feb 20, 2024 •
edited by github-actions bot

BugWPB-6271 [Android] Fix crashes during enrollment and show proper error details

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Fixed and refactored the error handling for E2EI
Needs releases with:

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.
References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@mchenani
fix(e2ei): error handling
dcf7983
@mchenani
Merge branch 'release/candidate' of https://github.com/wireapp/wire-a…
5036d51 
…ndroid-reloaded into release/fix-e2ei-error-handling

# Conflicts:
#	app/src/main/kotlin/com/wire/android/feature/e2ei/GetE2EICertificateUseCase.kt
#	app/src/main/kotlin/com/wire/android/ui/home/sync/FeatureFlagNotificationViewModel.kt
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 20, 2024 •
edited

Test Results

12 tests   12 ✅  0s ⏱️
 3 suites   0 💤
 3 files     0 ❌

Results for commit 395b238.

♻️ This comment has been updated with latest results.

@AndroidBob
Copy link
Collaborator

Build 3237 failed.

@mchenani mchenani enabled auto-merge (squash) February 23, 2024 08:26
@mchenani mchenani requested a review from Garzas February 23, 2024 08:30
@mchenani mchenani merged commit 16b4cdb into release/candidate Feb 23, 2024
9 of 10 checks passed
@AndroidBob AndroidBob mentioned this pull request Feb 23, 2024
Merged
7 tasks
@github-actions GitHub Actions
Copy link
Contributor

APKs built during tests are available here. Scroll down to Artifacts!

@AndroidBob
Copy link
Collaborator

Build 3276 succeeded.

The build produced the following APK's:

vitorhugods pushed a commit that referenced this pull request Feb 23, 2024
@mchenani @vitorhugods
fix(e2ei): error handling (WPB-6271) (#2721)
b63999c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandreferris alexandreferris alexandreferris approved these changes

@Garzas Garzas Garzas approved these changes

@borichellow borichellow Awaiting requested review from borichellow

@vitorhugods vitorhugods Awaiting requested review from vitorhugods

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara

@saleniuk saleniuk Awaiting requested review from saleniuk

Assignees

@mchenani mchenani

Labels
size/XS
Projects
None yet
Milestone
No milestone
4 participants
@mchenani @AndroidBob @alexandreferris @Garzas