Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mls): set correct CipherSuite when establishing new created group #2749

Merged

Conversation

mchenani
Copy link
Member

@mchenani mchenani commented May 8, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Update CipherSuite in DB after conversation is established.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

github-actions bot commented May 8, 2024

Test Results

2 865 tests   2 742 ✔️  22s ⏱️
   491 suites     123 💤
   491 files           0

Results for commit 3815444.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/set-correct-cs-to-new-groups
Commit report: d5ba8d8
Test service: kalium-jvm

✅ 0 Failed, 2883 Passed, 107 Skipped, 7.22s Total Time

@mchenani mchenani merged commit 8d2325b into release/android-cycle-4.6 May 8, 2024
17 checks passed
@mchenani mchenani deleted the fix/set-correct-cs-to-new-groups branch May 8, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants