Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mls): set correct CipherSuite when establishing new created group (WPB-9038) 🍒 #2750

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 8, 2024

BugWPB-9038 [Android] Not possible to add users to an existing group with new cipher suite

This PR was automatically cherry-picked based on the following PR:

Original PR description:



PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Update CipherSuite in DB after conversation is established.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina changed the title fix(mls): set correct CipherSuite when establishing new created group 🍒 fix(mls): set correct CipherSuite when establishing new created group (WPB-9038) 🍒 May 13, 2024
@mchenani mchenani enabled auto-merge (squash) May 24, 2024 12:05
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor Author

github-actions bot commented May 24, 2024

Test Results

2 910 tests   2 892 ✔️  4m 28s ⏱️
       7 suites       18 💤
       7 files           0

Results for commit 5cc7bd6.

♻️ This comment has been updated with latest results.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/set-correct-cs-to-new-groups-cherry-pick
Commit report: 77dce11
Test service: kalium-jvm

✅ 0 Failed, 2941 Passed, 105 Skipped, 11.43s Total Time

@mchenani mchenani merged commit 13cc534 into release/candidate May 24, 2024
19 checks passed
@mchenani mchenani deleted the fix/set-correct-cs-to-new-groups-cherry-pick branch May 24, 2024 13:06
github-actions bot added a commit that referenced this pull request May 24, 2024
… (WPB-9038) 🍒 (#2750)

* Commit with unresolved merge conflicts

* resolve conflicts

* resolve conflicts

---------

Co-authored-by: Mojtaba Chenani <chenani@outlook.com>
Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Jun 11, 2024
… (WPB-9038) 🍒 (#2750) (#2785)

* Commit with unresolved merge conflicts

* resolve conflicts

* resolve conflicts

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mojtaba Chenani <chenani@outlook.com>
Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
Co-authored-by: Vitor Hugo Schwaab <vitor@schwaab.dev>
Co-authored-by: Mohamad Jaara <mohamad.jaara@wire.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants