fix(mls): set correct CipherSuite when establishing new created group (WPB-9038) 🍒 🍒 #2785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
… (WPB-9038) 🍒 (#2750) * Commit with unresolved merge conflicts * resolve conflicts * resolve conflicts --------- Co-authored-by: Mojtaba Chenani <chenani@outlook.com> Co-authored-by: Yamil Medina <yamilmedina@users.noreply.github.com>
github-actions
bot
added
type: bug / fix 🐞
👕 size: XS
🚨 Potential breaking changes
labels
yamilmedina
approved these changes
May 24, 2024
saleniuk
approved these changes
May 28, 2024
Datadog ReportBranch report: ✅ 0 Failed, 2958 Passed, 105 Skipped, 11.11s Total Time |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2785 +/- ##
===========================================
- Coverage 59.00% 58.74% -0.27%
===========================================
Files 1204 1216 +12
Lines 46763 47544 +781
Branches 4387 4501 +114
===========================================
+ Hits 27592 27928 +336
- Misses 17181 17598 +417
- Partials 1990 2018 +28
... and 140 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
vitorhugods
deleted the
fix/set-correct-cs-to-new-groups-cherry-pick-cherry-pick
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically cherry-picked based on the following PR:
Original PR description:
This PR was automatically cherry-picked based on the following PR:
Original PR description:
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Update CipherSuite in DB after conversation is established.
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.