Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests and move dropwizard to bom (pt2) #120

Merged
merged 5 commits into from
Nov 30, 2023

Conversation

yamilmedina
Copy link
Collaborator

@yamilmedina yamilmedina commented Nov 29, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Tests broken after migration of Dropwizard from v2 to v4.

Causes (Optional)

Migration of Dropwizard from 2 to 4.

Solutions

  • Fix tests after migration of Dropwizard from v2 to v4.
  • Use latest support of junit5 extensions from testing support

Depends on

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Nov 29, 2023
@yamilmedina yamilmedina marked this pull request as ready for review November 29, 2023 21:13
…patible

fix: migrating ws configuration to jakarta (pt3)
@yamilmedina yamilmedina merged commit cdb285b into fix/lithium-deps Nov 30, 2023
3 checks passed
@yamilmedina yamilmedina deleted the fix/tests-tojunit5 branch November 30, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants