Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: migrating ws configuration to jakarta (pt3) #121

Merged

Conversation

yamilmedina
Copy link
Collaborator

@yamilmedina yamilmedina commented Nov 29, 2023

What's new in this PR?

  • Config of dependencies and websocket to use jakarta
  • Using now wirebot/runtime:1.4.0 (jre 17)

Issues

Roman does not starts

Causes (Optional)

Broken dependencies in WS level, because of incompatible or pending to migrate from JEE to Jakarta + Jetty 11

Solutions

Configure it

Dependencies (Optional)

Migrated to java17, so also updated the version of the runtime to 1.4.0 since that image is based on JDK 17

Testing

Test Coverage (Optional)

How to Test

Manually tested, build locally and run roman, with these new configurations.

Wire 2023-11-29 at 22_03

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@yamilmedina yamilmedina self-assigned this Nov 29, 2023
@yamilmedina yamilmedina changed the title fix: migrating ws to jakarta fix: migrating ws configuration to jakarta (pt3) Nov 29, 2023
@yamilmedina yamilmedina merged commit e1c92d0 into fix/tests-tojunit5 Nov 30, 2023
3 checks passed
@yamilmedina yamilmedina deleted the fix/figure-itout-websocket-incompatible branch December 7, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants