Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reserved identifier violation #7

Closed
elfring opened this issue Jul 25, 2016 · 2 comments
Closed

reserved identifier violation #7

elfring opened this issue Jul 25, 2016 · 2 comments

Comments

@elfring
Copy link

elfring commented Jul 25, 2016 •
edited
Loading

I would like to point out that identifiers like "AVS_H__" and "ZCLIENTCALL__ENGINE_H" do eventually not fit to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?
@jspittka
Copy link

jspittka commented Aug 1, 2016

Thanks for taking the time to review our code and for pointing out this issue! I have created a ticket for our backlog.

@jspittka jspittka closed this as completed Aug 1, 2016
@elfring
Copy link
Author

elfring commented Aug 1, 2016

Would it be safer to keep this issue open until it will be really fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @jspittka